git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
From: Felipe Contreras <felipe.contreras@gmail.com>
To: git@vger.kernel.org
Cc: "Junio C Hamano" <gitster@pobox.com>,
	"Martin Ågren" <martin.agren@gmail.com>,
	"brian m . carlson" <sandals@crustytoothpaste.net>,
	"Felipe Contreras" <felipe.contreras@gmail.com>
Subject: [PATCH v4 07/12] doc: asciidoctor: reorganize extensions
Date: Tue,  8 Jun 2021 04:00:21 -0500	[thread overview]
Message-ID: <20210608090026.1737348-8-felipe.contreras@gmail.com> (raw)
In-Reply-To: <20210608090026.1737348-1-felipe.contreras@gmail.com>

There's no need to create verbose classes, we can do the same with a
simple block.

Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 Documentation/asciidoctor-extensions.rb | 34 +++++++++++--------------
 1 file changed, 15 insertions(+), 19 deletions(-)

diff --git a/Documentation/asciidoctor-extensions.rb b/Documentation/asciidoctor-extensions.rb
index 3dea106d00..f998a42249 100644
--- a/Documentation/asciidoctor-extensions.rb
+++ b/Documentation/asciidoctor-extensions.rb
@@ -1,26 +1,22 @@
 require 'asciidoctor/extensions'
 
-module Git
-  module Documentation
-    class LinkGitProcessor < Asciidoctor::Extensions::InlineMacroProcessor
-      def process(parent, target, attrs)
-        prefix = parent.document.attr('git-relative-html-prefix')
-        if parent.document.doctype == 'book'
-          "<ulink url=\"#{prefix}#{target}.html\">" \
-          "#{target}(#{attrs[1]})</ulink>"
-        elsif parent.document.basebackend? 'html'
-          %(<a href="#{prefix}#{target}.html">#{target}(#{attrs[1]})</a>)
-        elsif parent.document.basebackend? 'docbook'
-          "<citerefentry>\n" \
-            "<refentrytitle>#{target}</refentrytitle>" \
-            "<manvolnum>#{attrs[1]}</manvolnum>\n" \
-          "</citerefentry>"
-        end
+Asciidoctor::Extensions.register do
+
+  inline_macro :linkgit do
+    process do |parent, target, attrs|
+      prefix = parent.document.attr('git-relative-html-prefix')
+      if parent.document.doctype == 'book'
+        "<ulink url=\"#{prefix}#{target}.html\">" \
+        "#{target}(#{attrs[1]})</ulink>"
+      elsif parent.document.basebackend? 'html'
+        %(<a href="#{prefix}#{target}.html">#{target}(#{attrs[1]})</a>)
+      elsif parent.document.basebackend? 'docbook'
+        "<citerefentry>\n" \
+          "<refentrytitle>#{target}</refentrytitle>" \
+          "<manvolnum>#{attrs[1]}</manvolnum>\n" \
+        "</citerefentry>"
       end
     end
   end
-end
 
-Asciidoctor::Extensions.register do
-  inline_macro Git::Documentation::LinkGitProcessor, :linkgit
 end
-- 
2.32.0.2.g41be0a4e50


  parent reply	other threads:[~2021-06-08  9:02 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-08  9:00 [PATCH v4 00/12] doc: cleanup old cruft and asciidoctor revamp Felipe Contreras
2021-06-08  9:00 ` [PATCH v4 01/12] doc: remove GNU troff workaround Felipe Contreras
2021-06-08  9:00 ` [PATCH v4 02/12] doc: use --stringparam in xmlto Felipe Contreras
2021-06-08  9:00 ` [PATCH v4 03/12] doc: simplify version passing Felipe Contreras
2021-06-08  9:00 ` [PATCH v4 04/12] doc: asciidoc: remove unnecessary attribute Felipe Contreras
2021-06-08  9:00 ` [PATCH v4 05/12] doc: asciidoctor: remove unnecessary require Felipe Contreras
2021-06-08  9:00 ` [PATCH v4 06/12] doc: asciidoctor: remove cruft Felipe Contreras
2021-06-08  9:00 ` Felipe Contreras [this message]
2021-06-08  9:00 ` [PATCH v4 08/12] doc: asciidoctor: use html-prefix only for html Felipe Contreras
2021-06-08  9:00 ` [PATCH v4 09/12] doc: asciidoctor: refactor macro registration Felipe Contreras
2021-06-08  9:00 ` [PATCH v4 10/12] doc: asciidoctor: improve string handling Felipe Contreras
2021-06-08  9:00 ` [PATCH v4 11/12] doc: asciidoctor: split the format from the code Felipe Contreras
2021-06-08  9:00 ` [PATCH v4 12/12] doc: asciidoctor: specify name of our group Felipe Contreras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210608090026.1737348-8-felipe.contreras@gmail.com \
    --to=felipe.contreras@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=martin.agren@gmail.com \
    --cc=sandals@crustytoothpaste.net \
    --subject='Re: [PATCH v4 07/12] doc: asciidoctor: reorganize extensions' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).