From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS2044 198.145.29.0/24 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AE8FC433ED for ; Wed, 12 May 2021 20:35:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4643961408 for ; Wed, 12 May 2021 20:35:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239293AbhELUgM (ORCPT ); Wed, 12 May 2021 16:36:12 -0400 Received: from dcvr.yhbt.net ([64.71.152.64]:44640 "EHLO dcvr.yhbt.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241737AbhELSFl (ORCPT ); Wed, 12 May 2021 14:05:41 -0400 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id E5E441F5AE; Wed, 12 May 2021 18:04:31 +0000 (UTC) Date: Wed, 12 May 2021 18:04:31 +0000 From: Eric Wong To: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Cc: git@vger.kernel.org, Junio C Hamano , Gregory Anders , =?utf-8?B?xJBvw6BuIFRy4bqnbiBDw7RuZw==?= Danh , Jeff King Subject: Re: [PATCH 0/9] send-email: various optimizations to speed up by >2x Message-ID: <20210512180431.GA22854@dcvr> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Ævar Arnfjörð Bjarmason wrote: > As noted in the subject this speeds up git-send-email invocations by > ~2x or more, and brings the very slow t9001 test from running in ~26s > on my box to ~12s. It's no longer consistently the slowest test I run. > > This is basically done in two ways: We lazily invoke "git config" to > get config, before it's very eager, and deferring Perl compilation > with s/use/require/g. Nice. I've been doing similar things elsewhere and hoping to find time to get around to git-svn at some point. > Ævar Arnfjörð Bjarmason (9): > send-email: remove non-working support for "sendemail.smtpssl" > send-email: refactor sendemail.smtpencryption config parsing > send-email: lazily load config for a big speedup > send-email: lazily shell out to "git var" > send-email: use function syntax instead of barewords > send-email: get rid of indirect object syntax > send-email: lazily load modules for a big speedup > perl: lazily load some common Git.pm setup code > send-email: move trivial config handling to Perl I spotted some further optimizations for 7 and 8, but otherwise consider this series: Reviewed-by: Eric Wong