From: Matthias Beyer <mail@beyermatthias.de>
To: git@vger.kernel.org
Subject: signed-off-by not overwritten with GIT_AUTHOR_NAME...?
Date: Wed, 7 Apr 2021 15:42:01 +0200 [thread overview]
Message-ID: <20210407134201.kxijiev5sn346bsy@hoshi> (raw)
[-- Attachment #1: Type: text/plain, Size: 768 bytes --]
Hi,
I just found that overwriting the GIT_AUTHOR_EMAIL and GIT_AUTHOR_NAME env
variables does alter the author when committing, but does not overwrite the
--signoff entry. Is this intentional?
To reproduce:
cd /tmp
mkdir foo
cd foo
git init
touch foo
git add foo
GIT_AUTHOR_EMAIL=nobody@nomail.de GIT_AUTHOR_NAME="Someone Else" git commit -s -m test
git show
I'm tested this for 2.29.3 and 2.29.2.
The manpage (2.29.3) does not say anything related to that under the `--signoff`
entry, nor under the `COMMIT INFORMATION` section!
If this is a bug, I'd love to contribute a patch, if someone can take my hand
and guide me to the right places!
Please keep me in CC, I'm not subscribed.
--
Matthias
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next reply other threads:[~2021-04-07 13:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 13:42 Matthias Beyer [this message]
2021-04-07 13:54 ` signed-off-by not overwritten with GIT_AUTHOR_NAME...? Taylor Blau
2021-04-07 14:00 ` Matthias Beyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210407134201.kxijiev5sn346bsy@hoshi \
--to=mail@beyermatthias.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).