* [PATCH] test-bloom: fix missing 'bloom' from usage string
@ 2021-04-06 2:35 Christian Couder
2021-04-06 13:05 ` Derrick Stolee
0 siblings, 1 reply; 2+ messages in thread
From: Christian Couder @ 2021-04-06 2:35 UTC (permalink / raw)
To: git; +Cc: Junio C Hamano, Jeff King, Taylor Blau, Christian Couder
Like 'get_murmur3' and 'generate_filter', 'get_filter_for_commit' is a
subcommand of `test-tool bloom` not of `test-tool` itself.
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
---
t/helper/test-bloom.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/helper/test-bloom.c b/t/helper/test-bloom.c
index 2a1ae3dae6..ad3ef1cd77 100644
--- a/t/helper/test-bloom.c
+++ b/t/helper/test-bloom.c
@@ -48,7 +48,7 @@ static void get_bloom_filter_for_commit(const struct object_id *commit_oid)
static const char *bloom_usage = "\n"
" test-tool bloom get_murmur3 <string>\n"
" test-tool bloom generate_filter <string> [<string>...]\n"
-" test-tool get_filter_for_commit <commit-hex>\n";
+" test-tool bloom get_filter_for_commit <commit-hex>\n";
int cmd__bloom(int argc, const char **argv)
{
--
2.31.1.189.g2e36527f23
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] test-bloom: fix missing 'bloom' from usage string
2021-04-06 2:35 [PATCH] test-bloom: fix missing 'bloom' from usage string Christian Couder
@ 2021-04-06 13:05 ` Derrick Stolee
0 siblings, 0 replies; 2+ messages in thread
From: Derrick Stolee @ 2021-04-06 13:05 UTC (permalink / raw)
To: Christian Couder, git
Cc: Junio C Hamano, Jeff King, Taylor Blau, Christian Couder
On 4/5/2021 10:35 PM, Christian Couder wrote:
> Like 'get_murmur3' and 'generate_filter', 'get_filter_for_commit' is a
> subcommand of `test-tool bloom` not of `test-tool` itself.
>
> Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
> ---
> t/helper/test-bloom.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/t/helper/test-bloom.c b/t/helper/test-bloom.c
> index 2a1ae3dae6..ad3ef1cd77 100644
> --- a/t/helper/test-bloom.c
> +++ b/t/helper/test-bloom.c
> @@ -48,7 +48,7 @@ static void get_bloom_filter_for_commit(const struct object_id *commit_oid)
> static const char *bloom_usage = "\n"
> " test-tool bloom get_murmur3 <string>\n"
> " test-tool bloom generate_filter <string> [<string>...]\n"
> -" test-tool get_filter_for_commit <commit-hex>\n";
> +" test-tool bloom get_filter_for_commit <commit-hex>\n";
Obviously correct. Good find.
Thanks,
-Stolee
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-06 13:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-06 2:35 [PATCH] test-bloom: fix missing 'bloom' from usage string Christian Couder
2021-04-06 13:05 ` Derrick Stolee
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).