From: Madhu <enometh@meer.net>
To: gitster@pobox.com
Cc: git@vger.kernel.org
Subject: Re: [PATCH] init: don't reset core.filemode on git-new-workdirs.
Date: Tue, 23 Mar 2021 09:27:48 +0530 (IST) [thread overview]
Message-ID: <20210323.092748.1559327071188512317.enometh@meer.net> (raw)
In-Reply-To: <xmqqr1k76p8d.fsf@gitster.g>
* Junio C Hamano <gitster@pobox.com> <xmqqr1k76p8d.fsf@gitster.g>
Wrote on Mon, 22 Mar 2021 11:02:42 -0700
>> I don't think the posted patch (snipped) would work as reinit is
>> always 1 and we are always a candidate for reiniting - I may be
>> missing something.
>
> In other words, yes, the illustration patch you are responding to
> assumes that the "reinit" variable is set correctly (i.e. the HEAD
> exists and sensibly readable if you run "git init" in an already
> functioning working tree) and we can use it to avoid the filemode
> check.
Ah yes indeed.
>> Using a new file for the filemode test would be a natural
>> improvement.
>
> That becomes necessary only if we want to futz with core.filemode
> while doing "reinit", as .git/config can be a symlink. When we are
> creating a repository from scratch, we always create a regular file
> to prepare .git/config, and there is no need to do that, if we are
> happy to set core.filemode the same way as core.symlinks, i.e. only
> check once when the repository is created. No?
Avoiding the filemode check completely during reinit is ok with me
because it gave me wrong results. I can't speak for the original
author of the code - if his intention was to do it explicitly as part
of "reinitialization".
[In the latter case personally I'd want to edit the config file by hand
in response to a message from git - and I certainly do not want git to
change the config file behind my back without informing me.]
Thanks again.
next prev parent reply other threads:[~2021-03-23 4:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-21 12:28 [PATCH] init: don't reset core.filemode on git-new-workdirs Madhu
2021-03-21 21:58 ` Junio C Hamano
2021-03-22 2:40 ` Madhu
2021-03-22 4:53 ` Junio C Hamano
2021-03-22 9:04 ` Madhu
2021-03-22 18:02 ` Junio C Hamano
2021-03-23 3:57 ` Madhu [this message]
2021-03-23 6:39 ` Junio C Hamano
2021-03-23 16:53 ` Torsten Bögershausen
2021-03-23 17:45 ` Junio C Hamano
2021-03-23 20:31 ` Torsten Bögershausen
2021-03-23 20:50 ` Junio C Hamano
2021-06-18 4:18 ` Madhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210323.092748.1559327071188512317.enometh@meer.net \
--to=enometh@meer.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).