From: John Szakmeister <john@szakmeister.net>
To: git@vger.kernel.org, Jeff King <peff@peff.net>
Cc: Junio <gitster@pobox.com>, brian <sandals@crustytoothpaste.net>,
John Szakmeister <john@szakmeister.net>
Subject: [PATCH v3 2/2] http: drop the check for an empty proxy password before approving
Date: Thu, 11 Mar 2021 21:40:27 -0500 [thread overview]
Message-ID: <20210312024027.33418-3-john@szakmeister.net> (raw)
In-Reply-To: <20210312024027.33418-1-john@szakmeister.net>
credential_approve() already checks for a non-empty password before
saving, so there's no need to do the extra check here.
Signed-off-by: John Szakmeister <john@szakmeister.net>
---
http.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/http.c b/http.c
index 60d01c6e83..3aeabf0947 100644
--- a/http.c
+++ b/http.c
@@ -1635,8 +1635,7 @@ static int handle_curl_result(struct slot_results *results)
if (results->curl_result == CURLE_OK) {
credential_approve(&http_auth);
- if (proxy_auth.password)
- credential_approve(&proxy_auth);
+ credential_approve(&proxy_auth);
credential_approve(&cert_auth);
return HTTP_OK;
} else if (results->curl_result == CURLE_SSL_CERTPROBLEM) {
--
2.30.1
next prev parent reply other threads:[~2021-03-12 2:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-12 2:40 [PATCH v3 0/2] http: store credential when PKI auth is used John Szakmeister
2021-03-12 2:40 ` [PATCH v3 1/2] " John Szakmeister
2021-03-12 2:40 ` John Szakmeister [this message]
2021-03-12 21:03 ` [PATCH v3 0/2] " brian m. carlson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210312024027.33418-3-john@szakmeister.net \
--to=john@szakmeister.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).