git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: shubham verma <shubhunic@gmail.com>
To: git@vger.kernel.org
Subject: [PATCH v2 04/10] t7001: modernize subshell formatting
Date: Tue,  9 Feb 2021 23:02:48 +0530	[thread overview]
Message-ID: <20210209173254.17712-5-shubhunic@gmail.com> (raw)
In-Reply-To: <20210209173254.17712-1-shubhunic@gmail.com>

Some test use an old style for formatting subshells:

        (command &&
            ...

Update them to the modern style:

        (
            command &&
            ...

Signed-off-by: shubham verma <shubhunic@gmail.com>
---
 t/t7001-mv.sh | 74 ++++++++++++++++++++++++++++-----------------------
 1 file changed, 40 insertions(+), 34 deletions(-)

diff --git a/t/t7001-mv.sh b/t/t7001-mv.sh
index f63802442b..a4a14a3b2e 100755
--- a/t/t7001-mv.sh
+++ b/t/t7001-mv.sh
@@ -181,38 +181,42 @@ test_expect_success "Sergey Vlasov's test case" '
 	git mv ab a
 '
 
-test_expect_success 'absolute pathname' '(
-	rm -fr mine &&
-	mkdir mine &&
-	cd mine &&
-	test_create_repo one &&
-	cd one &&
-	mkdir sub &&
-	>sub/file &&
-	git add sub/file &&
-
-	git mv sub "$(pwd)/in" &&
-	! test -d sub &&
-	test -d in &&
-	git ls-files --error-unmatch in/file
-)'
-
-test_expect_success 'absolute pathname outside should fail' '(
-	rm -fr mine &&
-	mkdir mine &&
-	cd mine &&
-	out=$(pwd) &&
-	test_create_repo one &&
-	cd one &&
-	mkdir sub &&
-	>sub/file &&
-	git add sub/file &&
-
-	test_must_fail git mv sub "$out/out" &&
-	test -d sub &&
-	! test -d ../in &&
-	git ls-files --error-unmatch sub/file
-)'
+test_expect_success 'absolute pathname' '
+	(
+		rm -fr mine &&
+		mkdir mine &&
+		cd mine &&
+		test_create_repo one &&
+		cd one &&
+		mkdir sub &&
+		>sub/file &&
+		git add sub/file &&
+
+		git mv sub "$(pwd)/in" &&
+		! test -d sub &&
+		test -d in &&
+		git ls-files --error-unmatch in/file
+	)
+'
+
+test_expect_success 'absolute pathname outside should fail' '
+	(
+		rm -fr mine &&
+		mkdir mine &&
+		cd mine &&
+		out=$(pwd) &&
+		test_create_repo one &&
+		cd one &&
+		mkdir sub &&
+		>sub/file &&
+		git add sub/file &&
+
+		test_must_fail git mv sub "$out/out" &&
+		test -d sub &&
+		! test -d ../in &&
+		git ls-files --error-unmatch sub/file
+	)
+'
 
 test_expect_success 'git mv to move multiple sources into a directory' '
 	rm -fr .git && git init &&
@@ -503,14 +507,16 @@ test_expect_success 'moving a submodule in nested directories' '
 test_expect_success 'moving nested submodules' '
 	git commit -am "cleanup commit" &&
 	mkdir sub_nested_nested &&
-	(cd sub_nested_nested &&
+	(
+		cd sub_nested_nested &&
 		touch nested_level2 &&
 		git init &&
 		git add . &&
 		git commit -m "nested level 2"
 	) &&
 	mkdir sub_nested &&
-	(cd sub_nested &&
+	(
+		cd sub_nested &&
 		touch nested_level1 &&
 		git init &&
 		git add . &&
-- 
2.25.1


  parent reply	other threads:[~2021-02-09 17:35 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-09 17:32 [PATCH v2 00/10] Modernizing the t7001 test script shubham verma
2021-02-09 17:32 ` [PATCH v2 01/10] t7001: modernize test formatting shubham verma
2021-02-09 17:32 ` [PATCH v2 02/10] t7001: indent with TABs instead of spaces shubham verma
2021-02-09 17:32 ` [PATCH v2 03/10] t7001: remove unnecessary blank lines shubham verma
2021-02-09 17:32 ` shubham verma [this message]
2021-02-09 17:32 ` [PATCH v2 05/10] t7001: remove whitespace after redirect operators shubham verma
2021-02-09 17:32 ` [PATCH v2 06/10] t7001: avoid using `cd` outside of subshells shubham verma
2021-02-09 17:32 ` [PATCH v2 07/10] t7001: use '>' rather than 'touch' shubham verma
2021-02-09 17:32 ` [PATCH v2 08/10] t7001: put each command on a separate line shubham verma
2021-02-09 17:32 ` [PATCH v2 09/10] t7001: use here-docs instead of echo shubham verma
2021-02-09 17:32 ` [PATCH v2 10/10] t7001: use `test` rather than `[` shubham verma
2021-02-09 19:24 ` [PATCH v2 00/10] Modernizing the t7001 test script Eric Sunshine
2021-02-09 22:58 ` Junio C Hamano
2021-02-11  7:28   ` Eric Sunshine
2021-02-11  7:37     ` Junio C Hamano
2021-02-11  7:56       ` Shubham Verma
2021-02-11  7:59         ` Eric Sunshine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210209173254.17712-5-shubhunic@gmail.com \
    --to=shubhunic@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).