From: "Torsten Bögershausen" <firstname.lastname@example.org> To: Junio C Hamano <email@example.com> Cc: firstname.lastname@example.org, email@example.com, firstname.lastname@example.org Subject: Re: [PATCH v4 1/1] MacOS: precompose_argv_prefix() Date: Fri, 5 Feb 2021 18:31:56 +0100 Message-ID: <20210205173156.6ypl2q56r6gzutac@tb-raspi4> (raw) In-Reply-To: <email@example.com> On Wed, Feb 03, 2021 at 02:13:53PM -0800, Junio C Hamano wrote: > Junio C Hamano <firstname.lastname@example.org> writes: > > > Just as the prefix-less variant was idempotent and that was the > > reason why cmd_diff_files() had its own precompose() even if the > > incoming argv is supposed to be already precomposed because it > > was processed in another call to precompose() in run_builtin(), > > this patch keeps these seemingly redundant calls, because it is not > > meant as a clean-up but as a bugfix for the prefix part. > > > > OK. ... Ah, no, the call in run_builtin() is a new thing. We didn't > > have it, and the redundant call is what this patch introduced, so > > we need to be a bit more careful about the analysis here. It is one > > thing to say "we leave the existing iffy code and address only a > > single bug" and do so. It is entirely different to say so and then > > do "we introduce an iffy code and address only a single bug". We > > need to admit that what we added _is_ iffy but supposed to be safe. > > Just saying "it is supposed to be safe" without saying why it is > > iffy is dishonest and does not help future developers who may want > > to jump in and clean the code. > > > > Perhaps > > > > Now add it into git.c::run_builtin() as well. Existing > > precompose calls in diff-files.c and others would become > > redundant but because we do not want to make sure that there > > is no way for the control to reach them without passing > > run_builtin(), we'll keep them in place just in case. The > > calls to precompose() are idempotent so it should not hurt. > > > > or something? > > FYI, I've tweaked the proposed log message like the following before > queuing. I think that would be explicit enough to remind us that we > may be able to improve the situation fairly easily. > Thanks for helping me out. That gives me some time to look deeper and prepare more test cases ana a then cleanup on top of this patch (later).
prev parent reply other threads:[~2021-02-05 17:37 UTC|newest] Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-06 11:35 git-bugreport-2021-01-06-1209.txt (git can't deal with special characters) Daniel Troger 2021-01-06 14:21 ` Torsten Bögershausen 2021-01-06 16:49 ` Daniel Troger 2021-01-06 21:47 ` Torsten Bögershausen 2021-01-06 22:21 ` Daniel Troger 2021-01-06 23:07 ` Randall S. Becker 2021-01-07 14:34 ` Philippe Blain 2021-01-07 15:49 ` Torsten Bögershausen 2021-01-07 16:21 ` Philippe Blain 2021-01-08 19:07 ` Torsten Bögershausen 2021-01-24 15:13 ` [PATCH/RFC v1 1/1] git restore -p . and precomposed unicode tboegi 2021-01-24 19:51 ` Junio C Hamano 2021-01-25 16:53 ` Torsten Bögershausen 2021-01-29 17:15 ` [PATCH v2 1/1] MacOS: precompose_argv_prefix() tboegi 2021-01-29 23:19 ` Junio C Hamano 2021-01-31 0:43 ` Junio C Hamano 2021-01-31 9:50 ` Torsten =?unknown-8bit?Q?B=C3=B6gershausen?= 2021-02-02 15:11 ` [PATCH v3 " tboegi 2021-02-02 17:43 ` Junio C Hamano 2021-02-03 16:28 ` [PATCH v4 " tboegi 2021-02-03 19:33 ` Junio C Hamano 2021-02-03 22:13 ` Junio C Hamano 2021-02-05 17:31 ` Torsten Bögershausen [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210205173156.6ypl2q56r6gzutac@tb-raspi4 \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH v4 1/1] MacOS: precompose_argv_prefix()' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
firstname.lastname@example.org list mirror (unofficial, one of many) This inbox may be cloned and mirrored by anyone: git clone --mirror https://public-inbox.org/git git clone --mirror http://ou63pmih66umazou.onion/git git clone --mirror http://czquwvybam4bgbro.onion/git git clone --mirror http://hjrcffqmbrq6wope.onion/git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V1 git git/ https://public-inbox.org/git \ email@example.com public-inbox-index git Example config snippet for mirrors. Newsgroups are available over NNTP: nntp://news.public-inbox.org/inbox.comp.version-control.git nntp://ou63pmih66umazou.onion/inbox.comp.version-control.git nntp://czquwvybam4bgbro.onion/inbox.comp.version-control.git nntp://hjrcffqmbrq6wope.onion/inbox.comp.version-control.git nntp://news.gmane.io/gmane.comp.version-control.git note: .onion URLs require Tor: https://www.torproject.org/ code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git AGPL code for this site: git clone https://public-inbox.org/public-inbox.git