From: "Torsten Bögershausen" <email@example.com> To: Daniel Troger <firstname.lastname@example.org> Cc: Philippe Blain <email@example.com>, "Randall S. Becker" <firstname.lastname@example.org>, email@example.com, Johannes Schindelin <firstname.lastname@example.org> Subject: Re: git-bugreport-2021-01-06-1209.txt (git can't deal with special characters) Date: Sat, 16 Jan 2021 18:24:48 +0100 Message-ID: <20210116172447.uroh2m5r3uvlbmih@tb-raspi4> (raw) In-Reply-To: <653FE799-B0D6-471A-8801-834C6CA409E3@icloud.com> On Wed, Jan 13, 2021 at 03:57:03PM +0100, Daniel Troger wrote: > Hej Torsten, > > > To clean up the repo, you can do like this, explained in a dummy repo: > > your commands to remove one of the versions worked perfectly, thanks! > > > And I still womder, how did you mange to create the "decomposed version of å" ? > > I created the directory with finder or atom I suppose, I did not find an mkdir command for that directory in my 290MB of bash history. > > > I digged some hours into the stuff, add lots of debug traces, patches and stuff > > If I understand correctly, you already came up with a patch? That's great news! It's fine if it takes time as long as it gets fixed eventually. That is a more tricky thing than I thought. When Git starts, it runs getcwd() to find out where you started. Inside that whole path there is the Git repo to be found, and the whole path split into to parts: The part pointing out the repo and the part inside the repo. This is done in setup.c, and it seems as if we need to precompose the whole path, to work correctly. However, the configuration saying "core.precomposeunicode" has not been read yet. And setup.c doesn't know, where to find it, that is my understanding. When I patch the getcwd() function to try to read the configuration, it doesn't find it (yet). It can find the global (or system) config. Technically speaking, that can be used, but will probably cause other problems, since sometimes the (repo) local configuration is different, sometimes not. As far as I understand today, the best thing we can do is to check, if getcwd() may need a precomposition: precompose and see if the result is different. Then error out, telling the user that you can not run Git inside this directory. I don't know, if this is worth the effort. But: If somebody comes up with a patch, I am happy to review it and/or get it into shape.
next prev parent reply other threads:[~2021-01-16 17:35 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-08 19:56 Daniel Troger 2021-01-09 17:23 ` Torsten Bögershausen 2021-01-13 14:57 ` Daniel Troger 2021-01-16 17:24 ` Torsten Bögershausen [this message] -- strict thread matches above, loose matches on Subject: below -- 2021-01-06 11:35 Daniel Troger 2021-01-06 14:21 ` Torsten Bögershausen 2021-01-06 16:49 ` Daniel Troger 2021-01-06 21:47 ` Torsten Bögershausen 2021-01-06 22:21 ` Daniel Troger 2021-01-06 23:07 ` Randall S. Becker 2021-01-07 14:34 ` Philippe Blain 2021-01-07 15:49 ` Torsten Bögershausen 2021-01-07 16:21 ` Philippe Blain 2021-01-08 19:07 ` Torsten Bögershausen
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210116172447.uroh2m5r3uvlbmih@tb-raspi4 \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
email@example.com list mirror (unofficial, one of many) This inbox may be cloned and mirrored by anyone: git clone --mirror https://public-inbox.org/git git clone --mirror http://ou63pmih66umazou.onion/git git clone --mirror http://czquwvybam4bgbro.onion/git git clone --mirror http://hjrcffqmbrq6wope.onion/git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V1 git git/ https://public-inbox.org/git \ firstname.lastname@example.org public-inbox-index git Example config snippet for mirrors. Newsgroups are available over NNTP: nntp://news.public-inbox.org/inbox.comp.version-control.git nntp://ou63pmih66umazou.onion/inbox.comp.version-control.git nntp://czquwvybam4bgbro.onion/inbox.comp.version-control.git nntp://hjrcffqmbrq6wope.onion/inbox.comp.version-control.git nntp://news.gmane.io/gmane.comp.version-control.git note: .onion URLs require Tor: https://www.torproject.org/ code repositories for the project(s) associated with this inbox: https://80x24.org/mirrors/git.git AGPL code for this site: git clone https://public-inbox.org/public-inbox.git