From: "SZEDER Gábor" <szeder.dev@gmail.com>
To: "René Scharfe" <l.s.r@web.de>
Cc: "Felipe Contreras" <felipe.contreras@gmail.com>,
git@vger.kernel.org, "Junio C Hamano" <gitster@pobox.com>,
"Jonathan Nieder" <jrnieder@gmail.com>,
"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Subject: Re: [PATCH v2 1/3] completion: bash: add __git_have_func helper
Date: Wed, 30 Dec 2020 19:00:08 +0100 [thread overview]
Message-ID: <20201230180008.GL8396@szeder.dev> (raw)
In-Reply-To: <1402dabd-089d-616a-ef79-ff1ae3fcb438@web.de>
On Wed, Dec 30, 2020 at 06:17:52PM +0100, René Scharfe wrote:
> > +__git_have_func () {
> > + declare -f $1 >/dev/null 2>/dev/null
> And then I wondered why use declare -f, which prints the function's
> body, when there is -F, which just prints the function's name. And why
> repeat /dev/null when redirecting stderr when the more shorter 2>&1
> would do the same? None of hat was introduced by you patch, of course.
> Anyway, this seems to work for me:
>
> __git_have_func () {
> case "$1" in
> -*) return 1 ;;
> esac
> declare -F "$1" >/dev/null 2>&1
> }
The Bash completion script should be usable from Zsh as well, and Zsh
only supports 'declare -f' but not '-F', see 06f44c3cc5 (completion:
make compatible with zsh, 2010-09-06). The Zsh version included in
the 16.04 based LTS setup that I have at hand doesn't yet seem to have
a (for us) usable 'declare -F' yet.
next prev parent reply other threads:[~2020-12-30 18:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-29 17:08 [PATCH v2 0/3] completion: make __git_complete public Felipe Contreras
2020-12-29 17:08 ` [PATCH v2 1/3] completion: bash: add __git_have_func helper Felipe Contreras
2020-12-30 17:17 ` René Scharfe
2020-12-30 17:39 ` Felipe Contreras
2020-12-30 17:58 ` Felipe Contreras
2021-01-06 8:30 ` Junio C Hamano
2020-12-30 18:00 ` SZEDER Gábor [this message]
2020-12-30 18:09 ` Felipe Contreras
2020-12-29 17:08 ` [PATCH v2 2/3] test: completion: add tests for __git_complete Felipe Contreras
2020-12-29 17:08 ` [PATCH v2 3/3] completion: add proper public __git_complete Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201230180008.GL8396@szeder.dev \
--to=szeder.dev@gmail.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=l.s.r@web.de \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).