From: Pratyush Yadav <email@example.com> To: Johannes Sixt <firstname.lastname@example.org> Cc: Stefan Haller <email@example.com>, firstname.lastname@example.org Subject: Re: [PATCH 0/2] git-gui: Auto-rescan on activate Date: Fri, 18 Dec 2020 01:40:51 +0530 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <firstname.lastname@example.org> Hi, On 17/12/20 08:45PM, Johannes Sixt wrote: > Am 01.11.20 um 18:05 schrieb Stefan Haller: > > Do an automatic rescan whenever the git-gui window receives focus. Most other > > GUI tools do this, and it's very convenient; no more pressing F5 manually. > > > > People who don't like this behavior can turn it off using > > "git config gui.autorescan false". > > > > Stefan Haller (2): > > git-gui: Delay rescan until idle time > > git-gui: Auto-rescan on activate > > > > git-gui.sh | 26 ++++++++++++++++++++++---- > > 1 file changed, 22 insertions(+), 4 deletions(-) > > > > I've been using these patches in the past days. > > I am still a bit ambivalent on whether I like the behavior. I do switch > among windows *a lot* and there is a short flicker on every rescan. And > there is muscle memory... This is part of the reason I am a little uneasy enabling it by default, and why I insist on having a loud and clear warning to the users about what is going on. > I observe a bug and a half: > > It is unclear which file is selected automatically when there are > unstaged changes. But there is one misbehavior: after I have invoked the > merge tool, resolved the conflict, and then switch back to Git GUI, the > conflicted file is not selected anymore when it is not the first file in > the list. That is *very* annoying. Haven't had a chance to try this out yet but AFAIK the last file should be correctly remembered. See below. > And then there is the following use-case. While Git GUI is not active > (think Git GUI and Gitk side-by-side and Gitk active), I click on a > particular file that is not at the top of the list; then Git GUI becomes > active and rescans, but also forgets on which file I have clicked. But I > expected the clicked-on file to become visible, which it doesn't, and I > have to click again. This is mildly annoying. Hmm, I don't see that on my system on Linux. The code to remember last open file is there in 'rescan_done'. So I don't understand why this becomes a problem on your system. -- Regards, Pratyush Yadav
next prev parent reply other threads:[~2020-12-17 20:14 UTC|newest] Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-01 17:05 Stefan Haller 2020-11-01 17:05 ` [PATCH 1/2] git-gui: Delay rescan until idle time Stefan Haller 2020-11-02 15:45 ` Pratyush Yadav 2020-11-02 19:29 ` Stefan Haller 2020-11-01 17:05 ` [PATCH 2/2] git-gui: Auto-rescan on activate Stefan Haller 2020-11-02 15:48 ` Pratyush Yadav 2020-11-02 19:31 ` Stefan Haller 2020-11-02 13:15 ` [PATCH 0/2] " Pratyush Yadav 2020-11-02 19:24 ` Stefan Haller 2020-11-03 16:16 ` [PATCH v2 0/1] " Stefan Haller 2020-11-03 16:16 ` [PATCH v2 1/1] " Stefan Haller 2020-11-14 19:14 ` Stefan Haller 2020-11-17 7:36 ` Pratyush Yadav 2020-11-17 11:13 ` Stefan Haller 2020-11-17 12:05 ` Pratyush Yadav 2020-11-18 9:17 ` Stefan Haller 2020-12-17 19:45 ` [PATCH 0/2] " Johannes Sixt 2020-12-17 20:10 ` Pratyush Yadav [this message] 2020-12-17 22:21 ` Johannes Sixt 2020-12-18 10:36 ` Stefan Haller 2020-12-18 18:07 ` Johannes Sixt
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH 0/2] git-gui: Auto-rescan on activate' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).