From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 014CE1F4B4 for ; Thu, 17 Dec 2020 19:05:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730214AbgLQTEC (ORCPT ); Thu, 17 Dec 2020 14:04:02 -0500 Received: from relay10.mail.gandi.net ([217.70.178.230]:34437 "EHLO relay10.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726548AbgLQTEC (ORCPT ); Thu, 17 Dec 2020 14:04:02 -0500 Received: from localhost (unknown [103.82.80.43]) (Authenticated sender: me@yadavpratyush.com) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 5F2D624000B; Thu, 17 Dec 2020 19:03:19 +0000 (UTC) Date: Fri, 18 Dec 2020 00:33:17 +0530 From: Pratyush Yadav To: Stefan Haller Cc: git@vger.kernel.org Subject: Re: [PATCH 1/1] git-gui: fix colored label backgrounds when using themed widgets Message-ID: <20201217190317.pbsozw7kl5vxtwmi@yadavpratyush.com> References: <20201122194537.41870-1-stefan@haller-berlin.de> <20201122194537.41870-2-stefan@haller-berlin.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201122194537.41870-2-stefan@haller-berlin.de> Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On 22/11/20 08:45PM, Stefan Haller wrote: > The aqua theme on Mac doesn't support changing the background color for labels > and frames [1]. Since the red, green, and yellow backgrounds of the labels for > unstaged and staged files and the diff pane are so important design elements of > git gui's main window, it's not acceptable for them to have grey backgrounds on > Mac. > > To work around this, simply use non-themed widgets for all labels on Mac. This > is not a big problem because labels don't look extremely different between the > themed and non-themed versions. There are subtle differences, but they are not > as bad as having the wrong background color. > > [1] https://stackoverflow.com/a/6723911 > > Signed-off-by: Stefan Haller > --- > lib/themed.tcl | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Applied to git-gui/master. Thanks. -- Regards, Pratyush Yadav