From: Pratyush Yadav <me@yadavpratyush.com>
To: Stefan Haller <stefan@haller-berlin.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/1] git-gui: fix colored label backgrounds when using themed widgets
Date: Fri, 18 Dec 2020 00:33:17 +0530 [thread overview]
Message-ID: <20201217190317.pbsozw7kl5vxtwmi@yadavpratyush.com> (raw)
In-Reply-To: <20201122194537.41870-2-stefan@haller-berlin.de>
On 22/11/20 08:45PM, Stefan Haller wrote:
> The aqua theme on Mac doesn't support changing the background color for labels
> and frames [1]. Since the red, green, and yellow backgrounds of the labels for
> unstaged and staged files and the diff pane are so important design elements of
> git gui's main window, it's not acceptable for them to have grey backgrounds on
> Mac.
>
> To work around this, simply use non-themed widgets for all labels on Mac. This
> is not a big problem because labels don't look extremely different between the
> themed and non-themed versions. There are subtle differences, but they are not
> as bad as having the wrong background color.
>
> [1] https://stackoverflow.com/a/6723911
>
> Signed-off-by: Stefan Haller <stefan@haller-berlin.de>
> ---
> lib/themed.tcl | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied to git-gui/master. Thanks.
--
Regards,
Pratyush Yadav
prev parent reply other threads:[~2020-12-17 19:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-22 19:45 [PATCH 0/1] git-gui: fix colored label backgrounds on Mac Stefan Haller
2020-11-22 19:45 ` [PATCH 1/1] git-gui: fix colored label backgrounds when using themed widgets Stefan Haller
2020-12-01 20:06 ` Pratyush Yadav
2020-12-02 8:52 ` Stefan Haller
2020-12-06 13:07 ` Pratyush Yadav
2020-12-08 15:20 ` Stefan Haller
2020-12-17 19:03 ` Pratyush Yadav [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201217190317.pbsozw7kl5vxtwmi@yadavpratyush.com \
--to=me@yadavpratyush.com \
--cc=git@vger.kernel.org \
--cc=stefan@haller-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).