From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.4 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id C45F11F86C for ; Tue, 1 Dec 2020 19:43:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729502AbgLATmB (ORCPT ); Tue, 1 Dec 2020 14:42:01 -0500 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:32979 "EHLO relay2-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726213AbgLATmB (ORCPT ); Tue, 1 Dec 2020 14:42:01 -0500 X-Originating-IP: 103.82.80.86 Received: from localhost (unknown [103.82.80.86]) (Authenticated sender: me@yadavpratyush.com) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id C958940003; Tue, 1 Dec 2020 19:41:18 +0000 (UTC) Date: Wed, 2 Dec 2020 01:11:16 +0530 From: Pratyush Yadav To: David Aguilar Cc: Miguel Boekhold , Efimov Vasily , Pat Thoyts , Junio C Hamano , git@vger.kernel.org Subject: Re: [PATCH] git-gui: ssh-askpass: add a checkbox to show the input text Message-ID: <20201201194116.mvm7svakxzyruybx@yadavpratyush.com> References: <20201107222039.13900-1-davvid@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201107222039.13900-1-davvid@gmail.com> Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On 07/11/20 02:20PM, David Aguilar wrote: > Hide the input text by default since the field is > commonly used for sensative informations such as passwords. > > Add a "Show input" checkbox to conditionally show the input. > > Helped-by: Miguel Boekhold > Signed-off-by: Efimov Vasily > Signed-off-by: David Aguilar Merged to git-gui/master. Thanks. -- Regards, Pratyush Yadav