From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 4B5501FB0D for ; Thu, 26 Nov 2020 01:31:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731698AbgKZB3F (ORCPT ); Wed, 25 Nov 2020 20:29:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58248 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730060AbgKZB3F (ORCPT ); Wed, 25 Nov 2020 20:29:05 -0500 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E2599C061A55 for ; Wed, 25 Nov 2020 17:29:04 -0800 (PST) Received: by mail-wm1-x344.google.com with SMTP id p22so486611wmg.3 for ; Wed, 25 Nov 2020 17:29:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=e7DqChdgkDIOcmUV2R1ooVv5JMni3yZPaAeRb7uAV4k=; b=rK/oKdbrbshMbHXSCR5fFjg7ob9NNSnYAwVVhnmywbjYaR9ehWZoeBYDF/7sVlSpkF 3c/KytptYb8pL3M0C2h7BB6SEPADzuctzkUGVZlsCKkzC4EAqtVRXVG+BGavhiC+v4Ii VAJ+M/lq+9/p2ACwB+K9BeoK6s8ew7yZHgbc6vVWnDXwHefeF5PIEb8bD7tPjny4g5TK ywnb03Q2FlcUw9L1YwemDhjqK4IQd9cLDNQAUPy+lNS0MgyTCBJnXltASie3YXErCXAM 1Bngs3M6gwwYSVODqPcNEkDBLnTDFe0Ofhbm/Fk6pM7L6OWL9LL3JU6977qs3w8L2lQa qkyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=e7DqChdgkDIOcmUV2R1ooVv5JMni3yZPaAeRb7uAV4k=; b=MeNh5oFsfPwp18YqPq5SZWjdZsoDwGdRH32KiNs56D0q9ITUPIfwNUNJwcmtql5DEg SjgNqj4dY8/DUPnrnD5PEVx5/b299qhHWydKHcYpWsK/mkRfN4YMNwbP+SFOaWCtUHYN NiwuZqRyTTmfIbO+kT2Ps8AmDxnzE3FBJgfyLMqBryBeWeGmhRiysQZpLePifrp9VuKT +/yvC/z4B/OFFAyoBVYakuUhnRt3YvHu3RUEL14RQkrr0dnkUHeqMPToEzRpuzvNv1fg 22quU6M/mvMvHXyF9Ux0kUC2O9qlTmEiTTufd0l6UeF++0bxeQ6W2L0oySLbRHGMTn6b fwEQ== X-Gm-Message-State: AOAM532AKALp2I83wevliBVgSX+DdYoYMDDEO1XrtvxcpumGk3p8sn8C ef3C3T9z88dYNvssbcpisUVJCkkQEKtsoA== X-Google-Smtp-Source: ABdhPJzCgFN29pJzXI4frPo5Ntr2PbRbZ6ynsKP8tdDT7kLN7m2dXvR2r5STiQndOC/DtH9H6k493g== X-Received: by 2002:a1c:e0c3:: with SMTP id x186mr494769wmg.64.1606354143428; Wed, 25 Nov 2020 17:29:03 -0800 (PST) Received: from vm.nix.is (vm.nix.is. [2a01:4f8:120:2468::2]) by smtp.gmail.com with ESMTPSA id q12sm6402523wmc.45.2020.11.25.17.29.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Nov 2020 17:29:02 -0800 (PST) From: =?UTF-8?q?=C3=86var=20Arnfj=C3=B6r=C3=B0=20Bjarmason?= To: git@vger.kernel.org Cc: Junio C Hamano , Jeff King , "brian m . carlson" , Eric Sunshine , Johannes Schindelin , =?UTF-8?q?=C3=86var=20Arnfj=C3=B6r=C3=B0=20Bjarmason?= Subject: [RFC/PATCH 03/12] mktag: remove redundant braces in one-line body "if" Date: Thu, 26 Nov 2020 02:28:45 +0100 Message-Id: <20201126012854.399-4-avarab@gmail.com> X-Mailer: git-send-email 2.29.2.222.g5d2a92d10f8 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org This minor stylistic churn is usually something we'd avoid, but if we don't do this then the file after changes in subsequent commits will only have this minor style inconsistency, so let's change this while we're at it. Signed-off-by: Ævar Arnfjörð Bjarmason --- builtin/mktag.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/builtin/mktag.c b/builtin/mktag.c index 603b55aca0..dc354828f7 100644 --- a/builtin/mktag.c +++ b/builtin/mktag.c @@ -161,9 +161,8 @@ int cmd_mktag(int argc, const char **argv, const char *prefix) if (argc != 1) usage("git mktag"); - if (strbuf_read(&buf, 0, 0) < 0) { + if (strbuf_read(&buf, 0, 0) < 0) die_errno("could not read from stdin"); - } /* Verify it for some basic sanity: it needs to start with "object \ntype\ntagger " */ -- 2.29.2.222.g5d2a92d10f8