git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: nate@roosteregg.cc
To: git@vger.kernel.org
Cc: Nate Avers <nate@roosteregg.cc>
Subject: [PATCH 2/2] t3301: test proper exit response to no-value notes.displayRef.
Date: Sun, 22 Nov 2020 22:23:42 -0500	[thread overview]
Message-ID: <20201123032342.24566-3-nate@roosteregg.cc> (raw)
In-Reply-To: <20201123032342.24566-1-nate@roosteregg.cc>

From: Nate Avers <nate@roosteregg.cc>

Signed-off-by: Nate Avers <nate@roosteregg.cc>
---
 t/t3301-notes.sh | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/t/t3301-notes.sh b/t/t3301-notes.sh
index 8f43303007..ca60faf480 100755
--- a/t/t3301-notes.sh
+++ b/t/t3301-notes.sh
@@ -672,6 +672,11 @@ test_expect_success 'notes.displayRef respects order' '
 	test_cmp expect-both-reversed actual
 '
 
+test_expect_success 'notes.displayRef with no value handled gracefully' '
+	test_must_fail git -c notes.displayRef log -0 --notes &&
+	test_must_fail git -c notes.displayRef diff-tree --notes HEAD
+'
+
 test_expect_success 'GIT_NOTES_DISPLAY_REF works' '
 	GIT_NOTES_DISPLAY_REF=refs/notes/commits:refs/notes/other \
 		git log -2 >actual &&
-- 
2.27.0


  parent reply	other threads:[~2020-11-23  3:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-23  3:23 [PATCH 0/2] Fix a segfault in git log --notes nate
2020-11-23  3:23 ` [PATCH 1/2] notes.c: fix a segfault in notes_display_config() nate
2020-11-23  6:59   ` Junio C Hamano
2020-11-23  3:23 ` nate [this message]
2020-11-23 18:44   ` [PATCH 2/2] t3301: test proper exit response to no-value notes.displayRef Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201123032342.24566-3-nate@roosteregg.cc \
    --to=nate@roosteregg.cc \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).