git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Stefan Haller <stefan@haller-berlin.de>
To: me@yadavpratyush.com
Cc: git@vger.kernel.org
Subject: [PATCH 0/1] git-gui: fix colored label backgrounds on Mac
Date: Sun, 22 Nov 2020 20:45:36 +0100	[thread overview]
Message-ID: <20201122194537.41870-1-stefan@haller-berlin.de> (raw)

Here's another attempt at fixing the colored label backgrounds when using themed
widgets on Mac. I sent a different approach a few weeks ago, which was to make
the gui.usettk option default to off on Mac. This was clearly not a good
solution. This time I'm presenting an approach that is a little less drastic;
it's still not ideal, but I feel it's an acceptable compromise.

Another problem that is improved by this is dark mode on Mac: in that mode the
label text was almost invisible, because it was black on a very dark grey
background.

Stefan Haller (1):
  git-gui: fix colored label backgrounds when using themed widgets

 lib/themed.tcl | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--
2.29.0.18.gf8c967e53c


             reply	other threads:[~2020-11-22 19:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-22 19:45 Stefan Haller [this message]
2020-11-22 19:45 ` [PATCH 1/1] git-gui: fix colored label backgrounds when using themed widgets Stefan Haller
2020-12-01 20:06   ` Pratyush Yadav
2020-12-02  8:52     ` Stefan Haller
2020-12-06 13:07       ` Pratyush Yadav
2020-12-08 15:20         ` Stefan Haller
2020-12-17 19:03   ` Pratyush Yadav

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201122194537.41870-1-stefan@haller-berlin.de \
    --to=stefan@haller-berlin.de \
    --cc=git@vger.kernel.org \
    --cc=me@yadavpratyush.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).