From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 1DA7C1F66F for ; Fri, 20 Nov 2020 00:18:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727168AbgKTAO7 (ORCPT ); Thu, 19 Nov 2020 19:14:59 -0500 Received: from cloud.peff.net ([104.130.231.41]:36192 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726386AbgKTAO7 (ORCPT ); Thu, 19 Nov 2020 19:14:59 -0500 Received: (qmail 463 invoked by uid 109); 20 Nov 2020 00:14:59 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Fri, 20 Nov 2020 00:14:59 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 1237 invoked by uid 111); 20 Nov 2020 00:14:58 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Thu, 19 Nov 2020 19:14:58 -0500 Authentication-Results: peff.net; auth=none Date: Thu, 19 Nov 2020 19:14:58 -0500 From: Jeff King To: Junio C Hamano Cc: SZEDER =?utf-8?B?R8OhYm9y?= , git@vger.kernel.org, Johannes Schindelin Subject: Re: [PATCH 1/2] tests: make sure nested lazy prereqs work reliably Message-ID: <20201120001458.GA274082@coredump.intra.peff.net> References: <20201118190414.32616-1-szeder.dev@gmail.com> <20201119155824.GB25426@coredump.intra.peff.net> <20201119175608.GA132922@coredump.intra.peff.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Thu, Nov 19, 2020 at 11:50:26AM -0800, Junio C Hamano wrote: > Jeff King writes: > > > I took a look at converting some of the existing tests. This seems to > > work. It's a bit longer to read, perhaps, but I kind of like that the > > expected outcome is all laid out. It also pollutes the test output less > > (e.g., if you wanted to count up skipped tests in the whole suite, you'd > > get a bunch of noise from t0000 for these uninteresting skips). > > > > Thoughts? I think this is something I'd do on top of your patch. > > Yes, it looks nice as the expectation is expressed much clearly. OK, then here's the whole thing. I ended up with a few more cleanups, too. This is all on top of Gábor's patches. It's conceptually independent, but the textual wrangling was annoying enough it didn't make any sense to require you to do it again during merging. ;) Plus I do not think either topic is high-risk nor urgent enough to worry too much about one blocking the other. The diffstat is scary, but it's mostly the final patch, which is pretty mechanical. [1/4]: t0000: keep clean-up tests together [2/4]: t0000: run prereq tests inside sub-test [3/4]: t0000: run cleaning test inside sub-test [4/4]: t0000: consistently use single quotes for outer tests t/t0000-basic.sh | 570 +++++++++++++++++++++++------------------------ 1 file changed, 284 insertions(+), 286 deletions(-) -Peff