From: Jeff King <firstname.lastname@example.org>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: "SZEDER Gábor" <email@example.com>,
"brian m. carlson" <firstname.lastname@example.org>,
"Junio C Hamano" <email@example.com>
Subject: Re: [PATCH] t5310-pack-bitmaps: skip JGit tests with SHA256
Date: Thu, 19 Nov 2020 10:44:58 -0500 [thread overview]
Message-ID: <20201119154458.GA25426@coredump.intra.peff.net> (raw)
On Thu, Nov 19, 2020 at 12:19:10PM +0100, Johannes Schindelin wrote:
> > Yeah, it's likely we'll need to just match the output of "jgit
> > --version". Since their support is hypothetical at this point, I think
> > it makes sense to go with your original patch. It does mean we'll later
> > have to remove the SHA1 prereq from those tests, but that's OK. It's not
> > very many tests, and your commit message clearly explains what is going
> > on.
> It's not just removing the SHA-1 prereq, but testing for a new-enough
> This most likely entails adding a new test helper to `t/helper/` that
> allows using `versioncmp()` via the command-line, with some clever way to
> indicate the different outcomes, and then using that in a new prereq.
> You know, if it was me, I would opt for the simpler (and future-proof)
> solution I presented above. But hey, if that complex solution using
> `versioncmp()` floats your boat, who am I to stop you.
But that was my (and Gábor's) point: it is not future proof, because we
don't know whether it is a sufficient test until we actually see a
version of JGit with the correct support.
Not only that, but your proposed solution relies on having commits in
the repository, which is not something that a prereq should be relying
We may or may not need the version check eventually, but my point is
that we should be punting on it until we know what is needed.
prev parent reply other threads:[~2020-11-19 15:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-13 21:53 [PATCH] t5310-pack-bitmaps: skip JGit tests with SHA256 SZEDER Gábor
2020-11-13 21:56 ` Taylor Blau
2020-11-13 23:43 ` brian m. carlson
2020-11-15 21:13 ` SZEDER Gábor
2020-11-15 22:08 ` Johannes Schindelin
2020-11-18 18:30 ` SZEDER Gábor
2020-11-18 18:45 ` Jeff King
2020-11-19 11:19 ` Johannes Schindelin
2020-11-19 15:44 ` Jeff King [this message]
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).