From: Jeff King <email@example.com> To: "SZEDER Gábor" <firstname.lastname@example.org> Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>, email@example.com, "brian m. carlson" <firstname.lastname@example.org>, Junio C Hamano <email@example.com> Subject: Re: [PATCH] t5310-pack-bitmaps: skip JGit tests with SHA256 Date: Wed, 18 Nov 2020 13:45:43 -0500 [thread overview] Message-ID: <20201118184543.GA3016@coredump.intra.peff.net> (raw) In-Reply-To: <20201118183022.GA8396@szeder.dev> On Wed, Nov 18, 2020 at 07:30:22PM +0100, SZEDER Gábor wrote: > > I wonder whether there is a way to change the `JGIT` prereq in a way > > that automagically will recognize a (future) SHA256-enabled JGit? > > Something like > > > > test_lazy_prereq JGIT ' > > jgit --version && > > test_have_prereq !SHA1 || > > test "$(git rev-list -n 1 HEAD)" = "$(jgit rev-list -n 1 HEAD)" > > ' > > > > What do you think? > > I'm not sure. It is surely a substantial effort to fully support > SHA256, and I suppose there will be JGit versions with only partial > support. I'm worried that there will be versions that can already > read SHA256 objects, but can't read/write SHA256 pack bitmaps, or > can't transfer/negotiate SHA256 objects yet (for t5512), so even > though they could fulfill such a prereq test above, the test would > still fail. Yeah, it's likely we'll need to just match the output of "jgit --version". Since their support is hypothetical at this point, I think it makes sense to go with your original patch. It does mean we'll later have to remove the SHA1 prereq from those tests, but that's OK. It's not very many tests, and your commit message clearly explains what is going on. -Peff
next prev parent reply other threads:[~2020-11-18 18:47 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-13 21:53 SZEDER Gábor 2020-11-13 21:56 ` Taylor Blau 2020-11-13 23:43 ` brian m. carlson 2020-11-15 21:13 ` SZEDER Gábor 2020-11-15 22:08 ` Johannes Schindelin 2020-11-18 18:30 ` SZEDER Gábor 2020-11-18 18:45 ` Jeff King [this message] 2020-11-19 11:19 ` Johannes Schindelin 2020-11-19 15:44 ` Jeff King
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201118184543.GA3016@coredump.intra.peff.net \ --firstname.lastname@example.org \ --cc=Johannes.Schindelin@gmx.de \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH] t5310-pack-bitmaps: skip JGit tests with SHA256' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).