From: Jeff King <peff@peff.net>
To: "René Scharfe" <l.s.r@web.de>
Cc: Git Mailing List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] archive: release refname after use
Date: Mon, 16 Nov 2020 19:28:39 -0500 [thread overview]
Message-ID: <20201117002839.GB13516@coredump.intra.peff.net> (raw)
In-Reply-To: <7692d2f3-0a3b-91cd-c454-9725b0a395a7@web.de>
On Sat, Nov 14, 2020 at 11:01:04PM +0100, René Scharfe wrote:
> parse_treeish_arg() uses dwim_ref() to set refname to a strdup'd string.
> Release it after use. Also remove the const qualifier from the refname
> member to signify that ownership of the string is handed to the struct,
> leaving cleanup duty with the caller of parse_treeish_arg(), thus
> avoiding a cast.
Yeah, I looked at the surrounding code and agree that this is the right
thing to do.
I wondered if it might make sense for the initialization and clearing
of this "archive_args" structure to go in a pair of matched functions,
but it probably isn't worth the trouble. write_archive() is the only
place where we will allocate and deallocate such a struct (the only
reason it is a type at all is to pass the set of values around the
stack).
-Peff
prev parent reply other threads:[~2020-11-17 0:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-14 22:01 [PATCH] archive: release refname after use René Scharfe
2020-11-17 0:28 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201117002839.GB13516@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=l.s.r@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).