From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 97CB91F66F for ; Thu, 12 Nov 2020 20:50:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727160AbgKLUti (ORCPT ); Thu, 12 Nov 2020 15:49:38 -0500 Received: from cloud.peff.net ([104.130.231.41]:56404 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727138AbgKLUti (ORCPT ); Thu, 12 Nov 2020 15:49:38 -0500 Received: (qmail 22126 invoked by uid 109); 12 Nov 2020 20:49:38 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Thu, 12 Nov 2020 20:49:38 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 1960 invoked by uid 111); 12 Nov 2020 20:49:37 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Thu, 12 Nov 2020 15:49:37 -0500 Authentication-Results: peff.net; auth=none Date: Thu, 12 Nov 2020 15:49:37 -0500 From: Jeff King To: Junio C Hamano Cc: git@vger.kernel.org, =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Subject: Re: [PATCH v2 0/2] Retire git-parse-remote Message-ID: <20201112204937.GB707750@coredump.intra.peff.net> References: <20201112203155.3342586-1-gitster@pobox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201112203155.3342586-1-gitster@pobox.com> Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Thu, Nov 12, 2020 at 12:31:53PM -0800, Junio C Hamano wrote: > This is based on Ævar's 5-patch series, which removed unused bits > from git-parse-remote one by one, before finally moving the remnant > to the only user to remove the file. > > Earlier I suggested an alternative arrangement of the series to just > lift what is still in use and then discard the rest without even > splitting them out into separate commits---it is easy to see what's > not used by grepping for names of the helper functions. FWIW, this arrangement makes much more sense to me. But I am happy with either (as long as the file is fully deleted in the end ;) ). -Peff