From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Demi M. Obenour" <athena@invisiblethingslab.com>,
Git <git@vger.kernel.org>
Subject: Re: check_refname_format allows refs with components that begin with -, even though `git tag` does not
Date: Tue, 10 Nov 2020 16:35:44 -0500 [thread overview]
Message-ID: <20201110213544.GA3263091@coredump.intra.peff.net> (raw)
In-Reply-To: <xmqqd00l6kj0.fsf@gitster.c.googlers.com>
On Tue, Nov 10, 2020 at 12:09:55PM -0800, Junio C Hamano wrote:
> > The best idea I had for a fix is to print names beginning with `-`
> > using the fully-qualified form, such as "refs/tags/-a". Also, `--`
> > is used as a delimiter in many commands, and can’t be escaped,
> > so disallowing it might be a good idea.
>
> I do not think there is anything to fix.
>
> Command line parsers of some commands may have to learn how to
> disambiguate such a strangely named tags and branches, though. Some
> commands do not know --end-of-options convention, for example.
I think there is at least one thing to fix: rev-parse never learned
about --end-of-options. It also seems to have some weirdness around
"--".
Here's a series which fixes it.
[1/3]: rev-parse: don't accept options after dashdash
[2/3]: rev-parse: put all options under the "-" check
[3/3]: rev-parse: handle --end-of-options
Documentation/git-rev-parse.txt | 8 ++-
builtin/rev-parse.c | 100 ++++++++++++++++++--------------
t/t1503-rev-parse-verify.sh | 13 +++++
t/t1506-rev-parse-diagnosis.sh | 25 ++++++++
4 files changed, 99 insertions(+), 47 deletions(-)
-Peff
next prev parent reply other threads:[~2020-11-10 21:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-10 19:32 check_refname_format allows refs with components that begin with -, even though `git tag` does not Demi M. Obenour
2020-11-10 20:09 ` Junio C Hamano
2020-11-10 21:35 ` Jeff King [this message]
2020-11-10 21:37 ` [PATCH 1/3] rev-parse: don't accept options after dashdash Jeff King
2020-11-10 21:38 ` [PATCH 2/3] rev-parse: put all options under the "-" check Jeff King
2020-11-10 21:40 ` [PATCH 3/3] rev-parse: handle --end-of-options Jeff King
2020-11-10 22:23 ` Junio C Hamano
2020-11-10 22:28 ` Demi M. Obenour
2020-11-11 2:22 ` Jeff King
2020-11-10 21:33 ` check_refname_format allows refs with components that begin with -, even though `git tag` does not Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201110213544.GA3263091@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=athena@invisiblethingslab.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).