From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id B957A1F66F for ; Tue, 10 Nov 2020 20:16:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726428AbgKJUQj (ORCPT ); Tue, 10 Nov 2020 15:16:39 -0500 Received: from cloud.peff.net ([104.130.231.41]:53332 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726179AbgKJUQj (ORCPT ); Tue, 10 Nov 2020 15:16:39 -0500 Received: (qmail 9108 invoked by uid 109); 10 Nov 2020 20:16:39 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Tue, 10 Nov 2020 20:16:39 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 4732 invoked by uid 111); 10 Nov 2020 20:16:38 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Tue, 10 Nov 2020 15:16:38 -0500 Authentication-Results: peff.net; auth=none Date: Tue, 10 Nov 2020 15:16:38 -0500 From: Jeff King To: Anders Waldenborg Cc: git@vger.kernel.org, christian.couder@gmail.com, jonathantanmy@google.com Subject: Re: [PATCH 17/21] trailer: don't treat line with prefix of known trailer as known Message-ID: <20201110201638.GG1987088@coredump.intra.peff.net> References: <20201025212652.3003036-1-anders@0x63.nu> <20201025212652.3003036-18-anders@0x63.nu> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20201025212652.3003036-18-anders@0x63.nu> Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Sun, Oct 25, 2020 at 10:26:48PM +0100, Anders Waldenborg wrote: > E.g if "Closes" is a configured trailer a line starting with "c:" > shouldn't be treated as a recognized trailer when looking for trailer > block. Would this mean that: Signed-off: is no longer an alias for: Signed-off-by: ? TBH that seems overall much more sane to me, but I wonder if it is breaking somebody's expectations. -Peff