From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 1081F1F66F for ; Tue, 10 Nov 2020 19:58:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731142AbgKJT6m (ORCPT ); Tue, 10 Nov 2020 14:58:42 -0500 Received: from cloud.peff.net ([104.130.231.41]:53272 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727851AbgKJT6m (ORCPT ); Tue, 10 Nov 2020 14:58:42 -0500 Received: (qmail 9002 invoked by uid 109); 10 Nov 2020 19:58:42 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Tue, 10 Nov 2020 19:58:42 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 4527 invoked by uid 111); 10 Nov 2020 19:58:41 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Tue, 10 Nov 2020 14:58:41 -0500 Authentication-Results: peff.net; auth=none Date: Tue, 10 Nov 2020 14:58:40 -0500 From: Jeff King To: Anders Waldenborg Cc: git@vger.kernel.org, christian.couder@gmail.com, jonathantanmy@google.com Subject: Re: [PATCH 08/21] trailer: keep track of conf in trailer_item Message-ID: <20201110195840.GD1987088@coredump.intra.peff.net> References: <20201025212652.3003036-1-anders@0x63.nu> <20201025212652.3003036-9-anders@0x63.nu> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20201025212652.3003036-9-anders@0x63.nu> Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Sun, Oct 25, 2020 at 10:26:39PM +0100, Anders Waldenborg wrote: > Signed-off-by: Anders Waldenborg For refactoring commits like this, it can help to even give one or two sentences saying why this moves us in a good direction. Probably it is obvious to you, who wrote the later commits already, but in isolation it's hard to say if it is good move direction or not. And maybe it would become apparent by the time I get to the end, but leading the reviewer along the string of refactorings is a good way to help them understand the end state, too. :) -Peff