From: Jeff King <peff@peff.net>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: Daniel Gurney <dgurney99@gmail.com>,
git@vger.kernel.org, Johannes.Schindelin@gmx.de
Subject: Re: [PATCH v2] compat/bswap.h: simplify MSVC endianness detection
Date: Tue, 10 Nov 2020 09:21:22 -0500 [thread overview]
Message-ID: <20201110142122.GA1311261@coredump.intra.peff.net> (raw)
In-Reply-To: <20201110023620.GH6252@camp.crustytoothpaste.net>
On Tue, Nov 10, 2020 at 02:36:20AM +0000, brian m. carlson wrote:
> > > Modern MSVC or Windows versions don't support big-endian, so it's
> > > unnecessary to consider architectures when using it.
> >
> > This made me wonder if we support any non-modern versions (which would
> > be negatively impacted).
>
> I'm pretty sure we don't. As I said, we're using several C99 features
> and that version precedes the C99 standard (and 1999).
Your response was much more thorough than I anticipated. What I was
really going for in the commit message was just laying out "modern" a
bit more clearly, like:
No version of MSVC or Windows has supported a big-endian platform
since the mid-90's. Git wouldn't build with these pre-C99 compilers
these days anyway, so we can assume that MSVC is always little-endian.
> I'm fine leaving the commit message as it stands, given the brevity of
> the patch and that in the technology field, the affected versions are
> not in any way "modern," but of course I wouldn't object to a reroll.
> It's fine, should that happen, to include any of this email in the
> commit message.
I often find that the briefer the patch, the more I need to revisit the
assumptions of the author (myself included!). :)
But I am also OK either way; when commit messages are insufficient, I
often go back to the list archive to get more details, and now it's well
documented here.
-Peff
prev parent reply other threads:[~2020-11-10 14:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-07 23:47 [PATCH] compat/bswap.h: Simplify MSVC endianness detection Daniel Gurney
2020-11-08 0:12 ` brian m. carlson
2020-11-08 9:57 ` [PATCH v2] compat/bswap.h: simplify " Daniel Gurney
2020-11-10 0:31 ` Jeff King
2020-11-10 2:36 ` brian m. carlson
2020-11-10 6:00 ` Junio C Hamano
2020-11-10 14:04 ` Johannes Schindelin
2020-11-10 15:35 ` Daniel Gurney
2020-11-10 15:47 ` Johannes Schindelin
2020-11-10 17:20 ` Junio C Hamano
2020-11-10 17:30 ` Junio C Hamano
2020-11-10 22:37 ` Johannes Schindelin
2020-11-10 14:21 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201110142122.GA1311261@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=dgurney99@gmail.com \
--cc=git@vger.kernel.org \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).