From: Jeff King <email@example.com> To: Elijah Newren <firstname.lastname@example.org> Cc: Junio C Hamano <email@example.com>, Git Mailing List <firstname.lastname@example.org> Subject: Re: What's cooking in git.git (Nov 2020, #02; Mon, 9) Date: Mon, 9 Nov 2020 20:03:46 -0500 [thread overview] Message-ID: <20201110010346.GA1269097@coredump.intra.peff.net> (raw) In-Reply-To: <CABPp-BGtO5bgoinmjc3=WwW+w7G4Js14iGvO_qQ6oF3EcQt7xQ@mail.gmail.com> On Mon, Nov 09, 2020 at 04:44:17PM -0800, Elijah Newren wrote: > > * en/strmap (2020-11-06) 15 commits > [...] > > Will merge to 'next'? > > Yes, please. Peff went over the series in detail and said it looked > good to him as of v4 (he also seemed fine with the extra change in v5 > that I made in response to your request). I'm not aware of any issues > or further requests, and believe it is done. I'll CC Peff just in > case he wants to change his mind and request any more changes here... I actually forgot to look over your strset_add() function carefully, so thanks for the reminder. :) It all looks good to me. Obviously the boolean return is flipped from my strset_check_and_add(), but I can't really think of a reason to prefer one over the other. -Peff
next prev parent reply other threads:[~2020-11-10 1:03 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-09 23:42 Junio C Hamano 2020-11-10 0:44 ` Elijah Newren 2020-11-10 1:03 ` Jeff King [this message] 2020-11-10 13:31 ` ds/maintenance-part-3 (was Re: What's cooking in git.git (Nov 2020, #02; Mon, 9)) Derrick Stolee 2020-11-16 23:56 ` Emily Shaffer 2020-11-17 0:40 ` Junio C Hamano 2020-11-17 1:07 ` Emily Shaffer 2020-11-17 13:56 ` Derrick Stolee 2020-11-17 19:18 ` Emily Shaffer 2020-11-17 19:34 ` Junio C Hamano 2020-11-17 21:12 ` Derrick Stolee 2020-11-19 2:16 ` Junio C Hamano 2020-11-19 13:25 ` Derrick Stolee 2020-11-19 15:53 ` Derrick Stolee 2020-11-19 18:06 ` Junio C Hamano
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201110010346.GA1269097@coredump.intra.peff.net \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: What'\''s cooking in git.git (Nov 2020, #02; Mon, 9)' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).