From: Daniel Gurney <dgurney99@gmail.com>
To: git@vger.kernel.org
Cc: sandals@crustytoothpaste.net, Johannes.Schindelin@gmx.de,
Daniel Gurney <dgurney99@gmail.com>
Subject: [PATCH] compat/bswap.h: Simplify MSVC endianness detection
Date: Sun, 8 Nov 2020 01:47:51 +0200 [thread overview]
Message-ID: <20201107234751.10661-1-dgurney99@gmail.com> (raw)
Modern MSVC or Windows versions don't support big-endian, so it's
unnecessary to consider architectures when using it.
Signed-off-by: Daniel Gurney <dgurney99@gmail.com>
---
compat/bswap.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/compat/bswap.h b/compat/bswap.h
index c0bb744adc..72f225eaa8 100644
--- a/compat/bswap.h
+++ b/compat/bswap.h
@@ -74,7 +74,7 @@ static inline uint64_t git_bswap64(uint64_t x)
}
#endif
-#elif defined(_MSC_VER) && (defined(_M_IX86) || defined(_M_X64))
+#elif defined(_MSC_VER)
#include <stdlib.h>
--
2.29.2
next reply other threads:[~2020-11-07 23:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-07 23:47 Daniel Gurney [this message]
2020-11-08 0:12 ` [PATCH] compat/bswap.h: Simplify MSVC endianness detection brian m. carlson
2020-11-08 9:57 ` [PATCH v2] compat/bswap.h: simplify " Daniel Gurney
2020-11-10 0:31 ` Jeff King
2020-11-10 2:36 ` brian m. carlson
2020-11-10 6:00 ` Junio C Hamano
2020-11-10 14:04 ` Johannes Schindelin
2020-11-10 15:35 ` Daniel Gurney
2020-11-10 15:47 ` Johannes Schindelin
2020-11-10 17:20 ` Junio C Hamano
2020-11-10 17:30 ` Junio C Hamano
2020-11-10 22:37 ` Johannes Schindelin
2020-11-10 14:21 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201107234751.10661-1-dgurney99@gmail.com \
--to=dgurney99@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).