mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: David Aguilar <>
To: Pratyush Yadav <>
Cc: Miguel Boekhold <>,
	Efimov Vasily <>,
	Pat Thoyts <>,
	Junio C Hamano <>,
Subject: [PATCH] git-gui: ssh-askpass: add a checkbox to show the input text
Date: Sat,  7 Nov 2020 14:20:39 -0800	[thread overview]
Message-ID: <> (raw)

Hide the input text by default since the field is
commonly used for sensative informations such as passwords.

Add a "Show input" checkbox to conditionally show the input.

Helped-by: Miguel Boekhold <>
Signed-off-by: Efimov Vasily <>
Signed-off-by: David Aguilar <>
 git-gui--askpass | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)

This patch gathers the submissions from the following sources:

diff --git a/git-gui--askpass b/git-gui--askpass
index 1c99ee8..71a536d 100755
--- a/git-gui--askpass
+++ b/git-gui--askpass
@@ -26,8 +26,21 @@ pack .m -side top -fill x -padx 20 -pady 20 -expand 1
 entry .e -textvariable answer -width 50
 pack .e -side top -fill x -padx 10 -pady 10
+proc on_show_input_changed {args} {
+	global show_input
+	if {$show_input} {
+		.e configure -show ""
+	} else {
+		.e configure -show "*"
+	}
+trace add variable show_input write "on_show_input_changed"
+set show_input 0
 if {!$yesno} {
-	.e configure -show "*"
+	checkbutton .cb_show -text "Show input" -variable show_input
+	pack .cb_show -side top -anchor nw
 frame .b

             reply	other threads:[~2020-11-07 22:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-07 22:20 David Aguilar [this message]
2020-12-01 19:41 ` [PATCH] git-gui: ssh-askpass: add a checkbox to show the input text Pratyush Yadav

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).