From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 8DF0A1F66F for ; Fri, 6 Nov 2020 17:52:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727357AbgKFRwm (ORCPT ); Fri, 6 Nov 2020 12:52:42 -0500 Received: from cloud.peff.net ([104.130.231.41]:50092 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725868AbgKFRwm (ORCPT ); Fri, 6 Nov 2020 12:52:42 -0500 Received: (qmail 20088 invoked by uid 109); 6 Nov 2020 17:52:42 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Fri, 06 Nov 2020 17:52:42 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 2454 invoked by uid 111); 6 Nov 2020 17:52:41 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Fri, 06 Nov 2020 12:52:41 -0500 Authentication-Results: peff.net; auth=none Date: Fri, 6 Nov 2020 12:52:41 -0500 From: Jeff King To: Junio C Hamano Cc: Patrick Steinhardt , git@vger.kernel.org Subject: Re: [PATCH 1/2] update-ref: Allow creation of multiple transactions Message-ID: <20201106175241.GA182486@coredump.intra.peff.net> References: <20201105192901.GA121650@coredump.intra.peff.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Thu, Nov 05, 2020 at 01:34:20PM -0800, Junio C Hamano wrote: > > The tests all look quite reasonable to me. Touching .git/refs like this > > is a bit gross (and something we may have to deal with if we introduce > > reftables, etc). But it's pretty pervasive in this file, so matching > > the existing style is the best option for now. > > > Shouldn't "git show-ref --verify" be usable portably across ref backends > to test if a well-formed ref was created (or was not created)? > > On the ref-creation side, there are cases where we need to directly > futz with the filesystem entity. For example, "git update-ref" > cannot be used to place a non-commit at "refs/heads/foo", so > something like > > git rev-parse HEAD^{tree} >.git/refs/heads/bad-branch > > cannot be avoided (this is a tangent but we probably should add a > way to force setting _any_ value to any ref, that may not even point > at an existing object or an object of a wrong type, to help test > scripts). > > But I do not think this is such a case. Yeah, I agree completely that we could be using rev-parse in this instance. But it's definitely not alone there: $ git grep -c test_path_is.*.git/refs t/t1400-update-ref.sh t/t1400-update-ref.sh:13 So it is a question of "do an ugly thing that fits in with neighbors" or "be inconsistent but set a good example". And I am OK with either. Of course, "improve the neighbors on top" would be better still. :) -Peff PS And yeah, I agree in the long run we may need some mechanism to override internal safeties in order to test broken cases with reftable. We have sometimes resorted to manually munging on-disk files in similar tests (e.g., for broken packs, etc), but it gets rather tricky.