From: Hu Keping <hukeping@huawei.com>
To: <git@vger.kernel.org>
Cc: <zhengjunling@huawei.com>, <zhuangbiaowei@huawei.com>,
<git@stormcloud9.net>, <rafa.almas@gmail.com>, <l.s.r@web.de>,
<gitster@pobox.com>
Subject: [PATCH] Lengthening FORMAT_PATCH_NAME_MAX to 80
Date: Thu, 5 Nov 2020 20:15:48 +0000 [thread overview]
Message-ID: <20201105201548.2333425-1-hukeping@huawei.com> (raw)
The file name of the patch generated by `git format-patch` usually be
truncated as there is less than 60 bytes left for the subject of commit
message exclude the prefix patch number, say "0001-".
As per the kernel documentation[1], it suggest the length of subject no
more than 75.
>
> [...]
> For these reasons, the ``summary`` must be no more than 70-75
> characters, and it must describe both what the patch changes, as well
> as why the patch might be necessary.
>
Considered the prefix patch number "0001-" would take 5 characters, increase
the FORMAT_PATCH_NAME_MAX to 80.
[1] https://www.kernel.org/doc/Documentation/process/submitting-patches.rst
Signed-off-by: Hu Keping <hukeping@huawei.com>
---
log-tree.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/log-tree.h b/log-tree.h
index 8fa79289ec..021aee0d21 100644
--- a/log-tree.h
+++ b/log-tree.h
@@ -33,7 +33,7 @@ void log_write_email_headers(struct rev_info *opt, struct commit *commit,
int maybe_multipart);
void load_ref_decorations(struct decoration_filter *filter, int flags);
-#define FORMAT_PATCH_NAME_MAX 64
+#define FORMAT_PATCH_NAME_MAX 80
void fmt_output_commit(struct strbuf *, struct commit *, struct rev_info *);
void fmt_output_subject(struct strbuf *, const char *subject, struct rev_info *);
void fmt_output_email_subject(struct strbuf *, struct rev_info *);
--
2.18.0.huawei.25
next reply other threads:[~2020-11-05 12:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-05 20:15 Hu Keping [this message]
2020-11-05 15:01 ` [PATCH] Lengthening FORMAT_PATCH_NAME_MAX to 80 Jeff King
2020-11-05 21:16 ` Junio C Hamano
2020-11-06 8:51 ` hukeping
2020-11-06 17:45 ` Junio C Hamano
2020-11-06 20:50 ` Junio C Hamano
2020-11-06 21:56 ` [PATCH] format-patch: make output filename configurable Junio C Hamano
2020-11-06 22:05 ` Eric Sunshine
2020-11-09 19:23 ` [PATCH v2] " Junio C Hamano
2020-11-10 0:23 ` Jeff King
2020-11-10 1:43 ` Junio C Hamano
2020-11-10 2:31 ` hukeping
2020-11-10 2:37 ` Junio C Hamano
2020-11-10 4:44 ` hukeping
2020-11-10 5:40 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201105201548.2333425-1-hukeping@huawei.com \
--to=hukeping@huawei.com \
--cc=git@stormcloud9.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=l.s.r@web.de \
--cc=rafa.almas@gmail.com \
--cc=zhengjunling@huawei.com \
--cc=zhuangbiaowei@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).