mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "brian m. carlson" <>
To: Emily Shaffer <>
	"Johannes Schindelin" <>,
	"SZEDER Gábor" <>
Subject: Re: [PATCH v2 0/2] rev-parse options for absolute or relative paths
Date: Thu, 5 Nov 2020 03:20:40 +0000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

[-- Attachment #1: Type: text/plain, Size: 2003 bytes --]

On 2020-11-04 at 23:01:57, Emily Shaffer wrote:
> Hiya, we took a look in the review club, but I'll try to keep it simple.
> On Fri, Oct 09, 2020 at 07:15:09PM +0000, brian m. carlson wrote:
> > 
> > There are a bunch of different situations in which one would like to
> > have an absolute and canonical or a relative path from Git.
> I think specifically you are interested in this situation:

Yes, that's the case I'm interested in.

> I think this would have been useful to see in the cover letter :) There
> was a lot of "but why" during the review club meeting.

Sorry about that.  When I'm sending patches to Git that benefit Git LFS,
I want to be careful to build features that are generally applicable and
don't just try to shove in features that benefit the project I maintain,
so I'm often a little hesitant to mention my particular use case and try
to let the patch stand on its own.  I know that there are several
competing projects in this space, and I want to be sensitive to not
privileging my own just because I'm a frequent contributor.

I'll try to strike a better balance here in the future.

> Also, there was some brief wondering: if this option is useful in 'git
> rev-parse', would it be useful in other commands too? I thought maybe it
> would be more useful as an arg to 'git' itself, but on inspection, not
> really - because you wouldn't be able to switch the format in the middle
> of a bunch of args, like you can now. The way it's written here,
> though, should mean a smooth transition to something like OPT__VERBOSE
> or OPT__QUIET if we discover lots of folks would find use.

Yeah, I think this could be a thing we add in the future, but I'm
generally comfortable with this being just in rev-parse, since that's
the command that folks tend to use when scripting, but we'll see if
other folks think differently.
brian m. carlson (he/him or they/them)
Houston, Texas, US

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 263 bytes --]

  reply	other threads:[~2020-11-05  3:20 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-09 19:15 [PATCH v2 0/2] rev-parse options for absolute or relative paths brian m. carlson
2020-10-09 19:15 ` [PATCH v2 1/2] abspath: add a function to resolve paths with missing components brian m. carlson
2020-10-09 21:10   ` Junio C Hamano
2020-10-10  1:10     ` brian m. carlson
2020-11-09 13:57       ` Johannes Schindelin
2020-11-09 13:55   ` Johannes Schindelin
2020-11-16  2:21     ` brian m. carlson
2020-10-09 19:15 ` [PATCH v2 2/2] rev-parse: add option for absolute or relative path formatting brian m. carlson
2020-11-09 14:46   ` Johannes Schindelin
2020-11-16  2:15     ` brian m. carlson
2020-11-04 23:01 ` [PATCH v2 0/2] rev-parse options for absolute or relative paths Emily Shaffer
2020-11-05  3:20   ` brian m. carlson [this message]
2020-11-09 13:33 ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).