From: Jeff King <email@example.com> To: Junio C Hamano <firstname.lastname@example.org> Cc: "SZEDER Gábor" <email@example.com>, "Sathyajith Bhat" <firstname.lastname@example.org>, email@example.com Subject: Re: Segfault in git when using git logs Date: Wed, 4 Nov 2020 08:31:29 -0500 [thread overview] Message-ID: <20201104133129.GA3030480@coredump.intra.peff.net> (raw) In-Reply-To: <firstname.lastname@example.org> On Tue, Nov 03, 2020 at 12:21:42PM -0800, Junio C Hamano wrote: > >> So something like this won't harm VS Code more than we currently do, > >> while telling users what is wrong with their command line? > > > > Yeah, I was wondering if we'd want the patch you sent, or if we should > > turn those die() calls into warning() and disable the flags up front. > [...] > >> diff --git c/builtin/log.c w/builtin/log.c Since we now have identified the caller that was passing in the bogus options, and it has already been fixed, I'm inclined to say we should go with your die() patch from earlier (modulo the pathspec.nr fixup) and call it done. Do you want to roll that up with a commit message? -Peff
next prev parent reply other threads:[~2020-11-04 13:31 UTC|newest] Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-02 13:59 Sathyajith Bhat 2020-11-02 14:43 ` Jeff King 2020-11-02 18:31 ` Junio C Hamano 2020-11-03 10:15 ` SZEDER Gábor 2020-11-03 11:21 ` Christian Couder 2020-11-03 16:10 ` Elijah Newren 2020-11-03 18:21 ` Jeff King 2020-11-03 18:34 ` Junio C Hamano 2020-11-03 18:57 ` Jeff King 2020-11-03 20:21 ` Junio C Hamano 2020-11-04 13:31 ` Jeff King [this message] 2020-11-04 16:26 ` Junio C Hamano 2020-11-04 17:54 ` Re*: " Junio C Hamano 2020-11-04 19:41 ` Jeff King 2020-11-04 20:16 ` Junio C Hamano 2020-11-04 20:35 ` [PATCH] log: diagnose -L used with pathspec as an error Junio C Hamano 2020-11-04 21:03 ` Jeff King 2020-11-03 18:46 ` Segfault in git when using git logs Derrick Stolee 2020-11-03 18:55 ` Sathyajith Bhat 2020-11-03 19:23 ` Jeff King 2020-11-03 20:07 ` Derrick Stolee 2020-11-03 21:04 ` Derrick Stolee 2020-11-04 15:49 ` Sathyajith Bhat
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201104133129.GA3030480@coredump.intra.peff.net \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: Segfault in git when using git logs' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).