From: Jeff King <firstname.lastname@example.org> To: Sathyajith Bhat <email@example.com> Cc: Derrick Stolee <firstname.lastname@example.org>, email@example.com Subject: Re: Segfault in git when using git logs Date: Tue, 3 Nov 2020 14:23:27 -0500 [thread overview] Message-ID: <20201103192327.GA462936@coredump.intra.peff.net> (raw) In-Reply-To: <CAMsWJsxyW=JUh=XGCkGG3LhOsZASwFHtx9b6ziNi_uHa918Scw@mail.gmail.com> On Tue, Nov 03, 2020 at 08:55:52PM +0200, Sathyajith Bhat wrote: > I believe it is GitLens  which is causing the incorrect behaviour. > I haven't had any crashes after I disabled GitLens, and that's the > only extension I've had which interacts with scm. > >  https://github.com/eamodio/vscode-gitlens That makes sense. It seems pretty clear that its log__file() function will produce this bogus combination. Despite having some indication that it knows about the documentation forbidding it: https://github.com/eamodio/vscode-gitlens/blob/6cfd9fdedd7c6ec3bfa732af7c418bbbecdfba54/src/git/git.ts#L805 I don't know that project's code well enough to say whether there is a higher-level bug there (the issue seems to be the "renames" flag being enabled along with startLine; maybe the caller is wrong to specify both). -Peff
next prev parent reply other threads:[~2020-11-03 19:23 UTC|newest] Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-02 13:59 Sathyajith Bhat 2020-11-02 14:43 ` Jeff King 2020-11-02 18:31 ` Junio C Hamano 2020-11-03 10:15 ` SZEDER Gábor 2020-11-03 11:21 ` Christian Couder 2020-11-03 16:10 ` Elijah Newren 2020-11-03 18:21 ` Jeff King 2020-11-03 18:34 ` Junio C Hamano 2020-11-03 18:57 ` Jeff King 2020-11-03 20:21 ` Junio C Hamano 2020-11-04 13:31 ` Jeff King 2020-11-04 16:26 ` Junio C Hamano 2020-11-04 17:54 ` Re*: " Junio C Hamano 2020-11-04 19:41 ` Jeff King 2020-11-04 20:16 ` Junio C Hamano 2020-11-04 20:35 ` [PATCH] log: diagnose -L used with pathspec as an error Junio C Hamano 2020-11-04 21:03 ` Jeff King 2020-11-03 18:46 ` Segfault in git when using git logs Derrick Stolee 2020-11-03 18:55 ` Sathyajith Bhat 2020-11-03 19:23 ` Jeff King [this message] 2020-11-03 20:07 ` Derrick Stolee 2020-11-03 21:04 ` Derrick Stolee 2020-11-04 15:49 ` Sathyajith Bhat
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201103192327.GA462936@coredump.intra.peff.net \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: Segfault in git when using git logs' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).