From: Jonathan Tan <jonathantanmy@google.com>
To: gitster@pobox.com
Cc: Johannes.Schindelin@gmx.de, git@vger.kernel.org,
jonathantanmy@google.com
Subject: Re: jc/sequencer-stopped-sha-simplify, was Re: What's cooking in git.git (Oct 2020, #04; Tue, 27)
Date: Mon, 2 Nov 2020 10:46:34 -0800 [thread overview]
Message-ID: <20201102184634.3280859-1-jonathantanmy@google.com> (raw)
In-Reply-To: <xmqqsg9rvc9z.fsf@gitster.c.googlers.com>
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
> > Hi Junio,
> >
> > On Tue, 27 Oct 2020, Junio C Hamano wrote:
> >
> >> * jc/sequencer-stopped-sha-simplify (2020-10-21) 1 commit
> >> - sequencer: tolerate abbreviated stopped-sha file
> >>
> >> Recently the format of an internal state file "rebase -i" uses has
> >> been tightened up for consistency, which would hurt those who start
> >> "rebase -i" with old git and then continue with new git. Loosen
> >> the reader side a bit (which we may want to tighten again in a year
> >> or so).
> >>
> >> Is this a real issue, or just a theoretical one?
> >> cf. <xmqqd01b429a.fsf@gitster.c.googlers.com>
> >
> > We had a similar situation when we decided to fix the incorrect quoting in
> > the `author-script` file, and we decided that we have to be careful:
> > https://lore.kernel.org/git/nycvar.QRO.7.76.6.1807271415410.10478@tvgsbejvaqbjf.bet/
> >
> > In light of that, I think we should go with Jonathan's patch for a couple
> > of versions before tightening the reader side again.
>
> I do not mind taking the approach as a prudent and careful thing,
> but I want the question answered regardless, as I know Jonathan is
> in a good position to tell if this is just a theoretical issue than
> I am, and depending on the answer, we may rethink the approach of
> trying to be overly careful.
From what I see, this is just a theoretical issue for now. (I spotted it
while looking at the code, not because of a bug report.)
next prev parent reply other threads:[~2020-11-02 18:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-27 23:33 What's cooking in git.git (Oct 2020, #04; Tue, 27) Junio C Hamano
2020-11-02 1:47 ` jc/sequencer-stopped-sha-simplify, was " Johannes Schindelin
2020-11-02 18:34 ` Junio C Hamano
2020-11-02 18:46 ` Jonathan Tan [this message]
2020-11-02 18:51 ` Junio C Hamano
2020-11-02 1:50 ` jk/committer-date-is-author-date-fix-simplify, " Johannes Schindelin
2020-11-02 18:57 ` Junio C Hamano
2020-11-02 1:58 ` sj/untracked-files-in-submodule-directory-is-not-dirty, " Johannes Schindelin
2020-11-03 1:01 ` Junio C Hamano
2020-11-02 2:37 ` ag/merge-strategies-in-c, " Johannes Schindelin
2020-11-02 21:36 ` Junio C Hamano
2020-11-02 22:31 ` Alban Gruin
2020-11-03 0:32 ` Junio C Hamano
2020-11-04 13:22 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201102184634.3280859-1-jonathantanmy@google.com \
--to=jonathantanmy@google.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).