From: Patrick Steinhardt <ps@pks.im>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Jeff King" <peff@peff.net>,
git@vger.kernel.org, "SZEDER Gábor" <szeder.dev@gmail.com>,
"Taylor Blau" <me@ttaylorr.com>
Subject: Re: [PATCH v4] refs: implement reference transaction hook
Date: Mon, 26 Oct 2020 08:43:03 +0100 [thread overview]
Message-ID: <20201026074303.GA972@ncase> (raw)
In-Reply-To: <xmqqpn59k2xw.fsf@gitster.c.googlers.com>
[-- Attachment #1: Type: text/plain, Size: 2381 bytes --]
On Thu, Oct 22, 2020 at 08:59:23PM -0700, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
>
> > So I wonder if:
> >
> > diff --git a/t/t1416-ref-transaction-hooks.sh b/t/t1416-ref-transaction-hooks.sh
> > index f6e741c6c0..8155522a1a 100755
> > --- a/t/t1416-ref-transaction-hooks.sh
> > +++ b/t/t1416-ref-transaction-hooks.sh
> > @@ -9,6 +9,7 @@ test_expect_success setup '
> > test_commit PRE &&
> > PRE_OID=$(git rev-parse PRE) &&
> > test_commit POST &&
> > + PRE_OID=$(git rev-parse PRE) &&
> > POST_OID=$(git rev-parse POST)
> > '
> >
> > @@ -52,10 +53,10 @@ test_expect_success 'hook gets all queued updates in prepared state' '
> > fi
> > EOF
> > cat >expect <<-EOF &&
> > - $ZERO_OID $POST_OID HEAD
> > - $ZERO_OID $POST_OID refs/heads/master
> > + $PRE_OID $POST_OID HEAD
> > + $PRE_OID $POST_OID refs/heads/master
> > EOF
> > - git update-ref HEAD POST <<-EOF &&
> > + git update-ref HEAD POST POST <<-EOF &&
> > update HEAD $ZERO_OID $POST_OID
> > update refs/heads/master $ZERO_OID $POST_OID
> > EOF
> > @@ -75,10 +76,10 @@ test_expect_success 'hook gets all queued updates in committed state' '
> > fi
> > EOF
> > cat >expect <<-EOF &&
> > - $ZERO_OID $POST_OID HEAD
> > - $ZERO_OID $POST_OID refs/heads/master
> > + $PRE_OID $POST_OID HEAD
> > + $PRE_OID $POST_OID refs/heads/master
> > EOF
> > - git update-ref HEAD POST &&
> > + git update-ref HEAD POST PRE &&
> > test_cmp expect actual
> > '
>
> I think that makes a lot of sense. In addition,
>
> > ... But we'd possibly want to actually change the behavior
> > to always send the actual ref value to the hook.
>
> I offhand do not see a reason why we shouldn't do that.
>
> Thanks for carefully thinking things through.
Thanks for having a look! I agree, changing this seems sensible to me.
In the end, the intention of the hook is to have a single script which
is able to verify all reference updates, no matter where they come from.
And behaving differently based on whether the user passed the zero OID
or not doesn't seem useful to me in that context.
We should also a better job than I did and describe what the old OID
actually is in the documentation.
@Taylor, given that you've already dug into the code: do you already
have plans to post a patch for this?
Patrick
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-10-26 7:43 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-02 8:25 [PATCH] refs: implement reference transaction hooks Patrick Steinhardt
2020-06-02 17:47 ` Junio C Hamano
2020-06-03 11:26 ` Patrick Steinhardt
2020-06-07 20:12 ` SZEDER Gábor
2020-06-08 5:36 ` Patrick Steinhardt
2020-06-02 18:09 ` SZEDER Gábor
2020-06-03 9:46 ` Patrick Steinhardt
2020-06-03 12:27 ` [PATCH v2] refs: implement reference transaction hook Patrick Steinhardt
2020-06-03 16:51 ` Taylor Blau
2020-06-04 7:36 ` Patrick Steinhardt
2020-06-15 16:46 ` Taylor Blau
2020-06-16 5:45 ` Patrick Steinhardt
2020-06-03 17:44 ` Han-Wen Nienhuys
2020-06-03 18:03 ` Junio C Hamano
2020-06-18 10:27 ` [PATCH v3] " Patrick Steinhardt
2020-06-18 22:23 ` Junio C Hamano
2020-06-19 6:56 ` [PATCH v4] " Patrick Steinhardt
2020-10-23 1:03 ` Jeff King
2020-10-23 3:59 ` Junio C Hamano
2020-10-23 19:57 ` Taylor Blau
2020-10-23 22:07 ` Taylor Blau
2020-10-26 7:43 ` Patrick Steinhardt [this message]
2020-10-26 23:52 ` Taylor Blau
2020-10-27 5:37 ` Jeff King
2020-10-28 18:22 ` Patrick Steinhardt
2020-10-23 20:00 ` Taylor Blau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201026074303.GA972@ncase \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=me@ttaylorr.com \
--cc=peff@peff.net \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).