From: Taylor Blau <me@ttaylorr.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Taylor Blau <me@ttaylorr.com>,
Nipunn Koorapati via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, Nipunn Koorapati <nipunn1313@gmail.com>
Subject: Re: [PATCH v2 0/2] fsmonitor inline / testing cleanup
Date: Thu, 22 Oct 2020 14:38:22 -0400 [thread overview]
Message-ID: <20201022183822.GA781760@nand.local> (raw)
In-Reply-To: <xmqqblgum7qk.fsf@gitster.c.googlers.com>
On Thu, Oct 22, 2020 at 11:32:51AM -0700, Junio C Hamano wrote:
> Taylor Blau <me@ttaylorr.com> writes:
> > I'm still iffy on whether or not this series makes sense to apply
> > without the rest of the code that depends on it, but I'll leave that up
> > to Junio whether he wants to take the series as it is now, or wait for
> > other patches to come in on top.
>
> Sorry but I am not sure what you mean by "the code that depends on
> it". Are these two functions unused anywhere in the code? If so,
> the right way to clean them up may not be to turn them from inline
> to a proper definition, but to remove them ;-).
>
> If they have existing callers and it can be demonstrated that their
> callers do not benefit from them being inline, that by itself is a
> worthy clean-up, without adding any more callers, no?
>
> Confused...
Sorry for the confusion. I mean the following:
- These functions have existing callers that Nipunn claims do not need
to be explicitly inlined.
- These functions are being moved to be part of the fsmonitor public
interface (presumably so that new callers can be added).
...And I was wondering whether you wanted to wait for new callers
before applying these to your tree.
Thanks,
Taylor
next prev parent reply other threads:[~2020-10-22 18:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-21 18:04 [PATCH 0/2] fsmonitor inline / testing cleanup Nipunn Koorapati via GitGitGadget
2020-10-21 18:04 ` [PATCH 1/2] fsmonitor: stop inline'ing mark_fsmonitor_valid / _invalid Alex Vandiver via GitGitGadget
2020-10-21 20:55 ` Taylor Blau
2020-10-21 21:24 ` Junio C Hamano
2020-10-21 21:31 ` Taylor Blau
2020-10-21 21:38 ` Junio C Hamano
2020-10-21 23:22 ` Nipunn Koorapati
2020-10-21 18:04 ` [PATCH 2/2] fsmonitor: make output of test-dump-fsmonitor more concise Alex Vandiver via GitGitGadget
2020-10-21 20:52 ` [PATCH 0/2] fsmonitor inline / testing cleanup Taylor Blau
2020-10-21 23:15 ` Nipunn Koorapati
2020-10-22 0:21 ` [PATCH v2 " Nipunn Koorapati via GitGitGadget
2020-10-22 0:21 ` [PATCH v2 1/2] fsmonitor: stop inline'ing mark_fsmonitor_valid / _invalid Alex Vandiver via GitGitGadget
2020-10-22 0:21 ` [PATCH v2 2/2] fsmonitor: make output of test-dump-fsmonitor more concise Alex Vandiver via GitGitGadget
2020-10-22 17:40 ` [PATCH v2 0/2] fsmonitor inline / testing cleanup Taylor Blau
2020-10-22 18:32 ` Junio C Hamano
2020-10-22 18:38 ` Taylor Blau [this message]
2020-10-22 19:14 ` Junio C Hamano
2020-10-22 20:59 ` Nipunn Koorapati
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201022183822.GA781760@nand.local \
--to=me@ttaylorr.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=nipunn1313@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).