From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jeff King <peff@peff.net>, Nikos Chantziaras <realnc@gmail.com>,
git@vger.kernel.org
Subject: Re: git svn log: Use of uninitialized value $sha1_short
Date: Wed, 21 Oct 2020 22:21:58 +0000 [thread overview]
Message-ID: <20201021222158.GJ490427@camp.crustytoothpaste.net> (raw)
In-Reply-To: <xmqqwnzj5mq5.fsf@gitster.c.googlers.com>
[-- Attachment #1: Type: text/plain, Size: 986 bytes --]
On 2020-10-21 at 20:48:50, Junio C Hamano wrote:
> Looks that way. '$::' as opposed to plain '$' threw the replacement
> off the track?
>
> perl/Git/SVN/Log.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git i/perl/Git/SVN/Log.pm w/perl/Git/SVN/Log.pm
> index 3858fcf27d..9c819188ea 100644
> --- i/perl/Git/SVN/Log.pm
> +++ w/perl/Git/SVN/Log.pm
> @@ -298,7 +298,7 @@ sub cmd_show_log {
> get_author_info($c, $1, $2, $3);
> } elsif (/^${esc_color}(?:tree|parent|committer) /o) {
> # ignore
> - } elsif (/^${esc_color}:\d{6} \d{6} $::sha1_short/o) {
> + } elsif (/^${esc_color}:\d{6} \d{6} $::oid_short/o) {
> push @{$c->{raw}}, $_;
> } elsif (/^${esc_color}[ACRMDT]\t/) {
> # we could add $SVN->{svn_path} here, but that requires
Yeah, this is correct. I'll try to get a format patch written up
tonight with this if nobody gets to it before me.
--
brian m. carlson (he/him or they/them)
Houston, Texas, US
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 263 bytes --]
next prev parent reply other threads:[~2020-10-21 22:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-21 18:42 git svn log: Use of uninitialized value $sha1_short Nikos Chantziaras
2020-10-21 20:26 ` Jeff King
2020-10-21 20:48 ` Junio C Hamano
2020-10-21 21:29 ` Jeff King
2020-10-21 22:29 ` brian m. carlson
2020-10-22 2:56 ` Jeff King
2020-10-21 22:21 ` brian m. carlson [this message]
2020-10-22 1:18 ` [PATCH] svn: use correct variable name for short OID brian m. carlson
2020-10-22 3:00 ` Jeff King
2020-10-22 3:24 ` Jeff King
2020-10-22 19:29 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201021222158.GJ490427@camp.crustytoothpaste.net \
--to=sandals@crustytoothpaste.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=realnc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).