git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Caleb Tillman <caleb.tillman@gmail.com>
To: git@vger.kernel.org
Cc: Caleb Tillman <caleb.tillman@gmail.com>
Subject: [Outreachy-Microproject][PATCH 1/1] t0000: replace 'test -[def]' with helpers
Date: Sun, 18 Oct 2020 06:10:52 +0000	[thread overview]
Message-ID: <20201018061052.32350-1-caleb.tillman@gmail.com> (raw)

The test_path_is* functions provide debug-friendly upon failure.

Signed-off-by: Caleb Tillman <caleb.tillman@gmail.com>
---
Outreachy microproject, revised submission.
 t/t0000-basic.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/t/t0000-basic.sh b/t/t0000-basic.sh
index 923281af93..eb99892a87 100755
--- a/t/t0000-basic.sh
+++ b/t/t0000-basic.sh
@@ -1191,7 +1191,7 @@ test_expect_success 'writing this tree with --missing-ok' '
 test_expect_success 'git read-tree followed by write-tree should be idempotent' '
 	rm -f .git/index &&
 	git read-tree $tree &&
-	test -f .git/index &&
+	test_path_is_file .git/index &&
 	newtree=$(git write-tree) &&
 	test "$newtree" = "$tree"
 '
-- 
2.25.1


             reply	other threads:[~2020-10-18  6:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-18  6:10 Caleb Tillman [this message]
2020-10-18 13:02 ` [Outreachy-Microproject][PATCH 1/1] t0000: replace 'test -[def]' with helpers Shourya Shukla
2020-10-18 18:38   ` Christian Couder
2020-10-18 18:42   ` Eric Sunshine
2020-10-18 23:36   ` Taylor Blau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201018061052.32350-1-caleb.tillman@gmail.com \
    --to=caleb.tillman@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).