From: Jeff King <peff@peff.net>
To: Nipunn Koorapati via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Nipunn Koorapati <nipunn1313@gmail.com>,
Alex Vandiver <alexmv@dropbox.com>
Subject: Re: [PATCH] dir.c: fix comments to agree with argument name
Date: Thu, 15 Oct 2020 12:07:25 -0400 [thread overview]
Message-ID: <20201015160725.GA1104947@coredump.intra.peff.net> (raw)
In-Reply-To: <pull.757.git.1602766160815.gitgitgadget@gmail.com>
On Thu, Oct 15, 2020 at 12:49:20PM +0000, Nipunn Koorapati via GitGitGadget wrote:
> diff --git a/dir.c b/dir.c
> index 78387110e6..4c79c4f0e1 100644
> --- a/dir.c
> +++ b/dir.c
> @@ -1040,9 +1040,9 @@ static int add_patterns_from_buffer(char *buf, size_t size,
> * an index if 'istate' is non-null), parse it and store the
> * exclude rules in "pl".
> *
> - * If "ss" is not NULL, compute SHA-1 of the exclude file and fill
> + * If "oid_stat" is not NULL, compute SHA-1 of the exclude file and fill
Makes sense. This changed as part of 4b33e60201 (dir: convert struct
sha1_stat to use object_id, 2018-01-28). Perhaps it would likewise make
sense to stop saying "SHA-1" here, and just say "hash" (or even "object
id", though TBH I think the fact that the hash is the same as an
object-id is largely an implementation detail).
-Peff
next prev parent reply other threads:[~2020-10-15 16:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-15 12:49 [PATCH] dir.c: fix comments to agree with argument name Nipunn Koorapati via GitGitGadget
2020-10-15 16:07 ` Jeff King [this message]
2020-10-15 18:41 ` Junio C Hamano
2020-10-15 19:33 ` Nipunn Koorapati
2020-10-15 19:41 ` Jeff King
2020-10-15 20:23 ` Junio C Hamano
2020-10-16 12:39 ` Nipunn Koorapati
2020-10-15 16:28 ` [PATCH v2] " Nipunn Koorapati via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201015160725.GA1104947@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=alexmv@dropbox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=nipunn1313@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).