From: Jeff King <peff@peff.net>
To: Sean McAllister <smcallis@google.com>
Cc: Git Mailing List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>,
Masaya Suzuki <masayasuzuki@google.com>,
Jonathan Nieder <jrnieder@gmail.com>
Subject: Re: [PATCH v2 3/3] http: automatically retry some requests
Date: Wed, 14 Oct 2020 15:34:56 -0400 [thread overview]
Message-ID: <20201014193456.GA365553@coredump.intra.peff.net> (raw)
In-Reply-To: <CAM4o00fO++JMNdES03JKRyxmZtiLjkrJ2nux0-TZYBdH2+0ijA@mail.gmail.com>
On Wed, Oct 14, 2020 at 01:10:46PM -0600, Sean McAllister wrote:
> On Wed, Oct 14, 2020 at 1:09 PM Sean McAllister <smcallis@google.com> wrote:
> >
> > On Tue, Oct 13, 2020 at 3:14 PM Jeff King <peff@peff.net> wrote:
> > >
> > > I do think you could be leveraging CURLINFO_RETRY_AFTER rather than
> > > implementing your own header parsing, though.
> > >
> > Ah I didn't know about CURLINFO_RETRY_AFTER, I'll look at that and use
> > it if I can.
> >
> I took a look, it looks like CURLINFO_RETRY_AFTER was only added in
> 7.66 (September, 2019), so
> I don't think it's reasonable to rely on it for getting the
> Retry-After value in this case.
I agree that's pretty recent.
How important is it that we respect it? I.e., we'd have some sane retry
behavior if the header is missing anyway. On older curl versions, how
bad would it be to just use that fallback behavior all the time?
-Peff
next prev parent reply other threads:[~2020-10-14 19:34 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-13 19:17 [PATCH v2 1/3] remote-curl: add testing for intelligent retry for HTTP Sean McAllister
2020-10-13 19:17 ` [PATCH v2 2/3] replace CURLOPT_FILE With CURLOPT_WRITEDATA Sean McAllister
2020-10-13 20:46 ` Junio C Hamano
2020-10-13 20:58 ` Jeff King
2020-10-13 21:16 ` Daniel Stenberg
2020-10-14 14:57 ` Jeff King
2020-10-14 14:29 ` Sean McAllister
2020-10-14 17:11 ` Sean McAllister
2020-10-13 19:17 ` [PATCH v2 3/3] http: automatically retry some requests Sean McAllister
2020-10-13 21:14 ` Junio C Hamano
2020-10-14 14:28 ` Sean McAllister
2020-10-14 15:25 ` Junio C Hamano
2020-10-13 21:14 ` Jeff King
2020-10-13 23:45 ` brian m. carlson
2020-10-14 15:17 ` Jeff King
2020-10-14 19:09 ` Sean McAllister
2020-10-14 19:10 ` Sean McAllister
2020-10-14 19:34 ` Jeff King [this message]
2020-10-14 22:38 ` Sean McAllister
2020-10-15 0:04 ` Jonathan Nieder
2020-10-15 16:14 ` Jeff King
2020-10-15 16:24 ` Junio C Hamano
2020-10-14 19:55 ` Jeff King
2020-10-14 22:46 ` Sean McAllister
2020-10-15 16:23 ` Jeff King
2020-10-15 16:33 ` Sean McAllister
2020-10-13 20:40 ` [PATCH v2 1/3] remote-curl: add testing for intelligent retry for HTTP Junio C Hamano
2020-10-14 16:56 ` Sean McAllister
2020-10-14 18:13 ` Junio C Hamano
2020-10-14 18:21 ` Sean McAllister
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201014193456.GA365553@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=masayasuzuki@google.com \
--cc=smcallis@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).