From: Pratyush Yadav <me@yadavpratyush.com>
To: Stefan Haller <stefan@haller-berlin.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] git-gui: Make usettk off by default on Mac OS X
Date: Wed, 14 Oct 2020 15:31:11 +0530 [thread overview]
Message-ID: <20201014100111.c43f2fqipc52dtsg@yadavpratyush.com> (raw)
In-Reply-To: <20201013190243.62313-1-stefan@haller-berlin.de>
Hi Stefan,
On 13/10/20 09:02PM, Stefan Haller wrote:
> This option is supposed to make a Tcl/Tk app look more like a native app
> for the respective platform. This doesn't seem to work on Mac, it looks
> worse than the non-ttk appearance (for instance, the colored pane
> headers are grey).
I think we should actually fix the root of the problem instead of just
fixing the symptoms by disabling ttk.
There were recently some changes to how git-gui works with ttk in commit
c02efc1 (git-gui: improve dark mode support, 2020-09-26). Are you
running git-gui with that commit? If yes, what results do you see with
it reverted. If no, what results do you see with it applied?
> Users who really prefer the ttk look can still turn it on with the
> gui.usettk config.
>
> Signed-off-by: Stefan Haller <stefan@haller-berlin.de>
> ---
> git-gui.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/git-gui.sh b/git-gui.sh
> index 867b8ce..f7e13ca 100755
> --- a/git-gui.sh
> +++ b/git-gui.sh
> @@ -897,7 +897,7 @@ set default_config(gui.fontui) [font configure font_ui]
> set default_config(gui.fontdiff) [font configure font_diff]
> # TODO: this option should be added to the git-config documentation
> set default_config(gui.maxfilesdisplayed) 5000
> -set default_config(gui.usettk) 1
> +set default_config(gui.usettk) [expr ![is_MacOSX]]
> set default_config(gui.warndetachedcommit) 1
> set default_config(gui.tabsize) 8
> set font_descs {
> --
> 2.29.0.rc1
>
--
Regards,
Pratyush Yadav
next prev parent reply other threads:[~2020-10-14 10:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-13 19:02 [PATCH] git-gui: Make usettk off by default on Mac OS X Stefan Haller
2020-10-13 19:08 ` Stefan Haller
2020-10-14 10:01 ` Pratyush Yadav [this message]
2020-10-14 10:27 ` Stefan Haller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201014100111.c43f2fqipc52dtsg@yadavpratyush.com \
--to=me@yadavpratyush.com \
--cc=git@vger.kernel.org \
--cc=stefan@haller-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).