git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "Samuel Čavoj" <samuel@cavoj.net>
To: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Cc: "Phillip Wood" <phillip.wood123@gmail.com>,
	"Samuel Čavoj" <samuel@cavoj.net>
Subject: [PATCH v3 1/3] t3435: use `test_config` instead of `git config`
Date: Tue, 13 Oct 2020 23:30:22 +0200	[thread overview]
Message-ID: <20201013213021.3671432-1-samuel@cavoj.net> (raw)

Replace usages of `git config` with `test_config` in t3435 to prevent
side-effects between tests.

Signed-off-by: Samuel Čavoj <samuel@cavoj.net>
---
changed v2 -> v3:
    - added this patch
---
 t/t3435-rebase-gpg-sign.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/t/t3435-rebase-gpg-sign.sh b/t/t3435-rebase-gpg-sign.sh
index b47c59c190..696cb6b6a4 100755
--- a/t/t3435-rebase-gpg-sign.sh
+++ b/t/t3435-rebase-gpg-sign.sh
@@ -27,7 +27,7 @@ test_rebase_gpg_sign () {
 	shift
 	test_expect_success "rebase $* with commit.gpgsign=$conf $will sign commit" "
 		git reset two &&
-		git config commit.gpgsign $conf &&
+		test_config commit.gpgsign $conf &&
 		set_fake_editor &&
 		FAKE_LINES='r 1 p 2' git rebase --force-rebase --root $* &&
 		$must_fail git verify-commit HEAD^ &&
@@ -63,7 +63,7 @@ test_rebase_gpg_sign   false -i --no-gpg-sign --gpg-sign
 
 test_expect_failure 'rebase -p --no-gpg-sign override commit.gpgsign' '
 	git reset --hard merged &&
-	git config commit.gpgsign true &&
+	test_config commit.gpgsign true &&
 	git rebase -p --no-gpg-sign --onto=one fork-point master &&
 	test_must_fail git verify-commit HEAD
 '
-- 
2.28.0


             reply	other threads:[~2020-10-14  9:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-13 21:30 Samuel Čavoj [this message]
2020-10-13 21:30 ` [PATCH v3 2/3] sequencer: fix gpg option passed to merge subcommand Samuel Čavoj
2020-10-15 16:47   ` Junio C Hamano
2020-10-13 21:30 ` [PATCH v3 3/3] sequencer: pass explicit --no-gpg-sign to merge Samuel Čavoj
2020-10-15 17:02   ` Junio C Hamano
2020-10-17 22:02     ` Samuel Čavoj
2020-10-17 22:34       ` Junio C Hamano
2020-10-17 23:16         ` Samuel Čavoj
2020-10-15 16:43 ` [PATCH v3 1/3] t3435: use `test_config` instead of `git config` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201013213021.3671432-1-samuel@cavoj.net \
    --to=samuel@cavoj.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=phillip.wood123@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).