From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id A07241F4B4 for ; Tue, 13 Oct 2020 20:58:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726753AbgJMU6m (ORCPT ); Tue, 13 Oct 2020 16:58:42 -0400 Received: from cloud.peff.net ([104.130.231.41]:59002 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726186AbgJMU6m (ORCPT ); Tue, 13 Oct 2020 16:58:42 -0400 Received: (qmail 13099 invoked by uid 109); 13 Oct 2020 20:58:42 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Tue, 13 Oct 2020 20:58:42 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 9108 invoked by uid 111); 13 Oct 2020 20:58:41 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Tue, 13 Oct 2020 16:58:41 -0400 Authentication-Results: peff.net; auth=none Date: Tue, 13 Oct 2020 16:58:41 -0400 From: Jeff King To: Junio C Hamano Cc: Sean McAllister , git@vger.kernel.org, masayasuzuki@google.com, jrnieder@gmail.com Subject: Re: [PATCH v2 2/3] replace CURLOPT_FILE With CURLOPT_WRITEDATA Message-ID: <20201013205841.GA3678071@coredump.intra.peff.net> References: <20201013191729.2524700-1-smcallis@google.com> <20201013191729.2524700-2-smcallis@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Tue, Oct 13, 2020 at 01:46:07PM -0700, Junio C Hamano wrote: > Sean McAllister writes: > > > CURLOPT_FILE has been deprecated since 2003. > > I thought that Dscho already mention this, but updating the above > description to mention that _WRITEDATA was introduce to overtake > _FILE as an equivalent in the same timeframe would be more helpful > to readers. Yes. But more important: - when is _FILE going away (or has it already in some versions)? - when did _WRITEDATA appear? IOW, as a reviewer I would want to make sure that we are not losing support for any reasonable version of libcurl, or that we are at least getting something in return (fixing an incompatibility with newer versions). >From the link Dscho dug up it looks like the answer to the second one is "long enough not to care", but the commit message should make that plain. -Peff