git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Stefan Haller <stefan@haller-berlin.de>
To: git@vger.kernel.org
Cc: me@yadavpratyush.com
Subject: [PATCH] git-gui: Make usettk off by default on Mac OS X
Date: Tue, 13 Oct 2020 21:02:43 +0200	[thread overview]
Message-ID: <20201013190243.62313-1-stefan@haller-berlin.de> (raw)

This option is supposed to make a Tcl/Tk app look more like a native app
for the respective platform. This doesn't seem to work on Mac, it looks
worse than the non-ttk appearance (for instance, the colored pane
headers are grey).

Users who really prefer the ttk look can still turn it on with the
gui.usettk config.

Signed-off-by: Stefan Haller <stefan@haller-berlin.de>
---
 git-gui.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/git-gui.sh b/git-gui.sh
index 867b8ce..f7e13ca 100755
--- a/git-gui.sh
+++ b/git-gui.sh
@@ -897,7 +897,7 @@ set default_config(gui.fontui) [font configure font_ui]
 set default_config(gui.fontdiff) [font configure font_diff]
 # TODO: this option should be added to the git-config documentation
 set default_config(gui.maxfilesdisplayed) 5000
-set default_config(gui.usettk) 1
+set default_config(gui.usettk) [expr ![is_MacOSX]]
 set default_config(gui.warndetachedcommit) 1
 set default_config(gui.tabsize) 8
 set font_descs {
-- 
2.29.0.rc1


             reply	other threads:[~2020-10-13 19:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-13 19:02 Stefan Haller [this message]
2020-10-13 19:08 ` [PATCH] git-gui: Make usettk off by default on Mac OS X Stefan Haller
2020-10-14 10:01 ` Pratyush Yadav
2020-10-14 10:27   ` Stefan Haller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201013190243.62313-1-stefan@haller-berlin.de \
    --to=stefan@haller-berlin.de \
    --cc=git@vger.kernel.org \
    --cc=me@yadavpratyush.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).