From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 5134B1F4B4 for ; Tue, 13 Oct 2020 19:01:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732322AbgJMTBR convert rfc822-to-8bit (ORCPT ); Tue, 13 Oct 2020 15:01:17 -0400 Received: from mx.pao1.isc.org ([149.20.64.53]:63556 "EHLO mx.pao1.isc.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727733AbgJMTBR (ORCPT ); Tue, 13 Oct 2020 15:01:17 -0400 Received: from zmx1.isc.org (zmx1.isc.org [149.20.0.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx.pao1.isc.org (Postfix) with ESMTPS id 0F1C93AB1AA; Tue, 13 Oct 2020 19:01:17 +0000 (UTC) Received: from zmx1.isc.org (localhost [127.0.0.1]) by zmx1.isc.org (Postfix) with ESMTPS id C813C16008D; Tue, 13 Oct 2020 19:01:16 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by zmx1.isc.org (Postfix) with ESMTP id B66F2160090; Tue, 13 Oct 2020 19:01:16 +0000 (UTC) Received: from zmx1.isc.org ([127.0.0.1]) by localhost (zmx1.isc.org [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id EcJhHPNrvsxd; Tue, 13 Oct 2020 19:01:16 +0000 (UTC) Received: from larwa.hq.kempniu.pl (unknown [212.180.223.213]) by zmx1.isc.org (Postfix) with ESMTPSA id F024016008D; Tue, 13 Oct 2020 19:01:15 +0000 (UTC) Date: Tue, 13 Oct 2020 21:01:13 +0200 From: =?utf-8?B?TWljaGHFgiBLxJlwaWXFhA==?= To: Johannes Schindelin Cc: git@vger.kernel.org Subject: Re: [PATCH v2 3/3] t: add -I tests Message-ID: <20201013190113.GB9341@larwa.hq.kempniu.pl> References: <20201001120606.25773-1-michal@isc.org> <20201012091751.19594-1-michal@isc.org> <20201012091751.19594-4-michal@isc.org> <20201013063846.GF3278@larwa.hq.kempniu.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Hi Johannes, > > First, let me say that the goal of minimizing the run time of a test > > suite is close to my heart (it is an issue at my day job). Yet, I > > assumed that this new test would not be detrimental to test suite run > > times as it takes about half a second to run t4069-diff-ignore-regex.sh > > on my machine - and (I hope) its contents are in line with the "tests > > are the best documentation" proverb. > > Sadly, the test is not quite as fast on Windows. I just ran this (on a not > quite idle machine, admittedly) and it ended in this: > > # passed all 11 test(s) > 1..11 > > real 0m51.470s > user 0m0.046s > sys 0m0.015s > > Yes, that's almost a minute. Out of curiosity: is that under Cygwin? I have seen shell-based tests finishing in 15 *seconds* on Unix-like systems and in 15 *minutes* under Cygwin, which would be in line with your measurements provided above. > > Right, neat, though this does not (yet) test: > > > > - the interaction between -I and --ignore-blank-lines (this is visible > > in code coverage), > > Right. Any chance you can finagle that in, e.g. by yet another `-e` > argument to the `sed` call? I will try in v3 (while also looking at what I can do for other missing -I tests I pointed out). -- Best regards, Michał Kępień