From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.1 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 7E9EF1F4B4 for ; Tue, 13 Oct 2020 15:18:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389228AbgJMPSE (ORCPT ); Tue, 13 Oct 2020 11:18:04 -0400 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:62299 "EHLO relay2-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389037AbgJMPR4 (ORCPT ); Tue, 13 Oct 2020 11:17:56 -0400 X-Originating-IP: 103.82.80.152 Received: from localhost (unknown [103.82.80.152]) (Authenticated sender: me@yadavpratyush.com) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id BE31F40013; Tue, 13 Oct 2020 15:17:53 +0000 (UTC) Date: Tue, 13 Oct 2020 20:47:51 +0530 From: Pratyush Yadav To: Stefan Haller Cc: git@vger.kernel.org Subject: Re: [PATCH] git-gui blame: prevent tool tips from sticking around after Command-Tab Message-ID: <20201013151751.bq2raujl6dok2tvv@yadavpratyush.com> References: <20201013132643.3209-1-stefan@haller-berlin.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201013132643.3209-1-stefan@haller-berlin.de> X-GND-Spam-Score: 400 X-GND-Status: SPAM Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Hi Stefan, > Subject: [PATCH] git-gui blame: prevent tool tips from sticking around Nitpick: ^ Add a ':' here. On 13/10/20 03:26PM, Stefan Haller wrote: > On Mac, tooltips are not automatically removed when a window loses > focus. Furthermore, mouse-move events are only dispatched to the active > window, which means that if we Command-tab to another application while > a tool tip is showing, the tool tip will stay there forever (in front of > other applications). So we must hide it manually when we lose focus. > > I'm doing this unconditionally here (i.e. without if {[is_MacOSX]}); it Nitpick: s/I'm doing this/Do this/. > shouldn't hurt on other platforms, even though they don't seem to have > this problem. Yes, I don't have this problem on Linux. But this patch does not make any visible difference/regressions either. > Signed-off-by: Stefan Haller > --- > lib/blame.tcl | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/blame.tcl b/lib/blame.tcl > index 62ec083..8441e10 100644 > --- a/lib/blame.tcl > +++ b/lib/blame.tcl > @@ -328,6 +328,7 @@ constructor new {i_commit i_path i_jump} { > bind $i [cb _show_tooltip $i @%x,%y] > bind $i [cb _hide_tooltip] > bind $i [cb _hide_tooltip] > + bind $i [cb _hide_tooltip] > bind_button3 $i " > [cb _hide_tooltip] > set cursorX %x Will apply with the two nitpicks above fixed. No need to resend. Thanks. -- Regards, Pratyush Yadav