git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: gitster@pobox.com, git@vger.kernel.org
Subject: Re: Patchwork now does the right thing with GGG submissions
Date: Mon, 12 Oct 2020 17:31:07 -0400	[thread overview]
Message-ID: <20201012213107.ad3j2wetrfs62pvp@chatter.i7.local> (raw)
In-Reply-To: <20201012193850.GE3740546@google.com>

On Mon, Oct 12, 2020 at 12:38:50PM -0700, Jonathan Nieder wrote:
> > Just FYI, I made the necessary tweaks to patchwork to make it 
> > properly
> > assign "From" for gitgitgadget submissions:
> >
> > https://patchwork.kernel.org/patch/11832689/
> 
> \o/ Thanks much for this.
> 
> For the curious, any links to the change behind the scenes that made
> that happens?  Does it use Sender[1] or a different field?  Does the
> change live in [2] or [3]?

See my other email explaining how it's implemented. As to where it lives 
-- it's implemented as a procmail rule:

:0
* ^From: .*<gitgitgadget@gmail\.com>
{
    :0 bw
    INBODYFROM=| formail -xfrom:

    :0 hfw
    * INBODYFROM ?? .
    | formail -I "From:$INBODYFROM"
}

Currently, we fully blow away the From:, but after the 2.2.2 upgrade 
we'll be setting it as X-Original-From if we don't find one already 
present.

It's my goal to start publishing these procmail rules as part of a git 
repo in the future, so you'll be able to see all rules that are applied 
to incoming mail before we pass it along for patchwork processing.

Best regards,
-K

      parent reply	other threads:[~2020-10-12 21:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20201012180034.tu4rmeoadhy5j4w7@chatter.i7.local>
2020-10-12 19:38 ` Patchwork now does the right thing with GGG submissions Jonathan Nieder
2020-10-12 20:36   ` Junio C Hamano
2020-10-12 21:27     ` Konstantin Ryabitsev
2020-10-12 21:31   ` Konstantin Ryabitsev [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201012213107.ad3j2wetrfs62pvp@chatter.i7.local \
    --to=konstantin@linuxfoundation.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jrnieder@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).