git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	Chris Webster <chris@webstech.net>,
	"Chris. Webster via GitGitGadget" <gitgitgadget@gmail.com>,
	git@vger.kernel.org
Subject: Re: [PATCH] ci: github action - add check for whitespace errors
Date: Fri, 9 Oct 2020 13:59:17 -0400	[thread overview]
Message-ID: <20201009175917.GA963340@coredump.intra.peff.net> (raw)
In-Reply-To: <xmqqtuv3tlkv.fsf@gitster.c.googlers.com>

On Fri, Oct 09, 2020 at 09:23:28AM -0700, Junio C Hamano wrote:

> I think this is exactly the use case that
> 
>     After the list reached a consensus that it is a good idea to apply the
>     patch, re-send it with "To:" set to the maintainer{current-maintainer}
>     and "cc:" the list{git-ml} for inclusion.
> 
> in Documentation/SubmittingPatches was written to address.
> 
> I usually pay attention to majority of topics and have them on my
> radar by getting involved in _some_ way in the discussion thread, so
> I often know when the patch(es) matured enough to be picked up
> without such a "this is the version after our discussion and it is
> as close to perfect as we can possibly make" resend.
> 
> But for some topics, I have no strong opinion on the exact shape of
> the final patch(es), and/or I have no expertise to offer to help the
> discussion to reach the final product.  In such a case, I'd be just
> waiting, without getting involved in the discussion, for trusted
> others to bring the posted patch to a completed form.  I think this
> is such a case.

As the other person in the discussion, I'm sufficiently convinced that
doing this just for PRs is a good step for now. I.e., I think the
"completed form" is just what was posted already (though I agree it is
often convenient to the maintainer to re-post the patch as part of the
ping).

-Peff

  reply	other threads:[~2020-10-09 17:59 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-22  7:28 [PATCH] ci: github action - add check for whitespace errors Chris. Webster via GitGitGadget
2020-09-22 17:07 ` Jeff King
2020-09-22 17:55   ` Junio C Hamano
2020-09-22 22:41     ` Chris Webster
2020-10-09  5:00       ` Chris Webster
2020-10-09 13:20         ` Johannes Schindelin
2020-10-09 16:23           ` Junio C Hamano
2020-10-09 17:59             ` Jeff King [this message]
2020-10-09 18:13               ` Junio C Hamano
2020-10-09 18:18                 ` Jeff King
2020-10-09 18:56                   ` Junio C Hamano
2020-10-10  5:26                     ` Chris Webster
2020-10-10  6:29                       ` Junio C Hamano
2020-09-22 22:17   ` Chris Webster
2020-09-24  6:51     ` Jeff King
2020-09-25  5:10       ` Chris Webster
2020-09-25  6:44         ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201009175917.GA963340@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=chris@webstech.net \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).