From: "SZEDER Gábor" <szeder.dev@gmail.com>
To: Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: Re: [PATCH v2 1/2] ci: skip GitHub workflow runs for already-tested commits/trees
Date: Fri, 9 Oct 2020 09:29:22 +0200 [thread overview]
Message-ID: <20201009072922.GC24813@szeder.dev> (raw)
In-Reply-To: <914868d558b1aa8ebec6e9196c5ae83a2bd566bf.1602170976.git.gitgitgadget@gmail.com>
On Thu, Oct 08, 2020 at 03:29:34PM +0000, Johannes Schindelin via GitGitGadget wrote:
> From: Johannes Schindelin <johannes.schindelin@gmx.de>
>
> When pushing a commit that has already passed a CI or PR build
> successfully, it makes sense to save some energy and time and skip the
> new build.
>
> Let's teach our GitHub workflow to do that.
>
> For good measure, we also compare the tree ID, which is what we actually
> test (the commit ID might have changed due to a reworded commit message,
> which should not affect the outcome of the run).
We have been doing this on Travis CI for a few years now. Does that
approach not work on GitHub actions? Please explain in the commit
message why a different approach is taken here.
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> ---
> .github/workflows/main.yml | 39 +++++++++++++++++++++++++++++++++++++-
> 1 file changed, 38 insertions(+), 1 deletion(-)
>
> diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
> index 5bd321e5e1..7391b46d61 100644
> --- a/.github/workflows/main.yml
> +++ b/.github/workflows/main.yml
> @@ -9,7 +9,7 @@ jobs:
> ci-config:
> runs-on: ubuntu-latest
> outputs:
> - enabled: ${{ steps.check-ref.outputs.enabled }}
> + enabled: ${{ steps.check-ref.outputs.enabled }}${{ steps.skip-if-redundant.outputs.enabled }}
> steps:
> - name: try to clone ci-config branch
> continue-on-error: true
> @@ -35,6 +35,43 @@ jobs:
> enabled=no
> fi
> echo "::set-output name=enabled::$enabled"
> + - name: skip if the commit or tree was already tested
> + id: skip-if-redundant
> + uses: actions/github-script@v3
> + if: steps.check-ref.outputs.enabled == 'yes'
> + with:
> + github-token: ${{secrets.GITHUB_TOKEN}}
> + script: |
> + // Figure out workflow ID, commit and tree
> + const { data: run } = await github.actions.getWorkflowRun({
> + owner: context.repo.owner,
> + repo: context.repo.repo,
> + run_id: context.runId,
> + });
> + const workflow_id = run.workflow_id;
> + const head_sha = run.head_sha;
> + const tree_id = run.head_commit.tree_id;
> +
> + // See whether there is a successful run for that commit or tree
> + const { data: runs } = await github.actions.listWorkflowRuns({
> + owner: context.repo.owner,
> + repo: context.repo.repo,
> + per_page: 500,
> + status: 'success',
> + workflow_id,
> + });
> + for (const run of runs.workflow_runs) {
> + if (head_sha === run.head_sha) {
> + core.warning(`Successful run for the commit ${head_sha}: ${run.html_url}`);
> + core.setOutput('enabled', ' but skip');
> + break;
> + }
> + if (tree_id === run.head_commit.tree_id) {
> + core.warning(`Successful run for the tree ${tree_id}: ${run.html_url}`);
> + core.setOutput('enabled', ' but skip');
> + break;
> + }
> + }
>
> windows-build:
> needs: ci-config
> --
> gitgitgadget
>
next prev parent reply other threads:[~2020-10-09 7:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-24 17:17 [PATCH] ci: fix GitHub workflow when on a tagged revision Johannes Schindelin via GitGitGadget
2020-04-24 20:50 ` Junio C Hamano
2020-04-24 21:12 ` Johannes Schindelin
2020-04-24 21:24 ` Junio C Hamano
2020-10-08 15:29 ` [PATCH v2 0/2] Do not skip tagged revisions in the GitHub workflow runs Johannes Schindelin via GitGitGadget
2020-10-08 15:29 ` [PATCH v2 1/2] ci: skip GitHub workflow runs for already-tested commits/trees Johannes Schindelin via GitGitGadget
2020-10-09 7:29 ` SZEDER Gábor [this message]
2020-10-09 11:13 ` Johannes Schindelin
2020-10-10 7:25 ` SZEDER Gábor
2020-10-11 10:28 ` Johannes Schindelin
2020-10-12 16:12 ` Junio C Hamano
2020-10-12 18:57 ` Johannes Schindelin
2020-10-15 17:17 ` Junio C Hamano
2020-10-15 19:39 ` Johannes Schindelin
2020-10-08 15:29 ` [PATCH v2 2/2] ci: do not skip tagged revisions in GitHub workflows Johannes Schindelin via GitGitGadget
2020-10-08 21:11 ` [PATCH v2 0/2] Do not skip tagged revisions in the GitHub workflow runs Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201009072922.GC24813@szeder.dev \
--to=szeder.dev@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=johannes.schindelin@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).